public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Nicolas Morey-Chaisemartin
	<NMoreyChaisemartin-l3A5Bk7waGM@public.gmane.org>
Cc: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH rdma-core stable-v15] verbs: Do not block QP attr_masks used by older kernels
Date: Tue, 14 Nov 2017 11:58:42 -0700	[thread overview]
Message-ID: <20171114185842.GE4263@ziepe.ca> (raw)
In-Reply-To: <0a24c63b-c108-3301-e78f-7e38d58f5bdb-l3A5Bk7waGM@public.gmane.org>

On Tue, Nov 14, 2017 at 07:50:45PM +0100, Nicolas Morey-Chaisemartin wrote:
> 
> 
> Le 14/11/2017 à 19:49, Jason Gunthorpe a écrit :
> > On Tue, Nov 14, 2017 at 08:04:51PM +0200, Leon Romanovsky wrote:
> >> On Tue, Nov 14, 2017 at 03:40:25PM +0100, Nicolas Morey-Chaisemartin wrote:
> >>> At least the RDMA CM in 4.3 will give user space structs with these bits
> >>> set. Those kernels require user space to pass those set bits back to the
> >>> kernel. Blocking them causes RDMA CM to be unusable on older kernels.
> >>>
> >>> Stable-fix: Drop changes to verbs.h of the original fix,
> >>>  that are not needed for the fix itself.
> >>>
> >>> Fixes: 3ca7a1031486 ("ibverbs: Add support for packet pacing")
> >>> Commit-id: ce88cef301b ("verbs: Do not block QP attr_masks used by older kernels")
> >>> Reported-by: Ram Amrani <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> >>> Signed-off-by: Jason Gunthorpe <jgunthorpe-uk2M96/98Pc@public.gmane.org>
> >>>
> >> You need to add your Signed-off-by.
> Yep. Will do when applying.
> 
> > And please add something like
> >
> >     commit 9276717b9e297a62d1151a43d1cd286213f68eb7 upstream.
> >
> > after the subject line for all patches ...
> 
> That's what the Commit-id is for :)
> Do you prefer Upstream-commit-id ?

Oh! Yes, that seems fine as is then

Jason


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2017-11-14 18:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-14 14:40 [PATCH rdma-core stable-v15] verbs: Do not block QP attr_masks used by older kernels Nicolas Morey-Chaisemartin
     [not found] ` <636b5412-e41e-40ed-46da-a0e83bd5b049-l3A5Bk7waGM@public.gmane.org>
2017-11-14 18:04   ` Leon Romanovsky
     [not found]     ` <20171114180451.GB18825-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-11-14 18:49       ` Jason Gunthorpe
     [not found]         ` <20171114184912.GD4263-uk2M96/98Pc@public.gmane.org>
2017-11-14 18:50           ` Nicolas Morey-Chaisemartin
     [not found]             ` <0a24c63b-c108-3301-e78f-7e38d58f5bdb-l3A5Bk7waGM@public.gmane.org>
2017-11-14 18:58               ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171114185842.GE4263@ziepe.ca \
    --to=jgg-uk2m96/98pc@public.gmane.org \
    --cc=NMoreyChaisemartin-l3A5Bk7waGM@public.gmane.org \
    --cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox