From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: "Michael J. Ruhl"
<michael.j.ruhl-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 4/4] ibacm: Use MONOTONIC time base to avoid timer expiration issues
Date: Tue, 14 Nov 2017 16:56:25 -0700 [thread overview]
Message-ID: <20171114235625.GF25894@ziepe.ca> (raw)
In-Reply-To: <20171114164352.24557.86825.stgit-K+u1se/DcYrLESAwzcoQNrvm/XP+8Wra@public.gmane.org>
On Tue, Nov 14, 2017 at 11:44:17AM -0500, Michael J. Ruhl wrote:
> static inline int event_wait(event_t *e, int timeout)
> {
> - struct timeval curtime;
> struct timespec wait;
> int ret;
>
> - gettimeofday(&curtime, NULL);
> - wait.tv_sec = curtime.tv_sec + ((unsigned) timeout) / 1000;
> - wait.tv_nsec = (curtime.tv_usec + (((unsigned) timeout) % 1000) * 1000) * 1000;
> + clock_gettime(CLOCK_MONOTONIC, &wait);
> + wait.tv_sec = wait.tv_sec + ((unsigned int) timeout) / 1000;
> + wait.tv_nsec = (wait.tv_nsec + (((unsigned int) timeout) % 1000) * 1000000);
since timeout must be positive just declare it as 'unsigned int' in the
function signature and all the ugly casts go away and the function
argument range is now documented..
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-14 23:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 16:43 [PATCH v3 0/4] ibacm: acmp retry issues Michael J. Ruhl
[not found] ` <20171114164006.24557.72093.stgit-K+u1se/DcYrLESAwzcoQNrvm/XP+8Wra@public.gmane.org>
2017-11-14 16:43 ` [PATCH v3 1/4] ibacm: Fix an incorrect expiration check for the retry timer Michael J. Ruhl
2017-11-14 16:43 ` [PATCH v3 2/4] ibacm: Calculate correct tv_nsec value in event_wait() Michael J. Ruhl
2017-11-14 16:43 ` [PATCH v3 3/4] ibacm: Fix a retry loop calculation race condition Michael J. Ruhl
[not found] ` <20171114164337.24557.45231.stgit-K+u1se/DcYrLESAwzcoQNrvm/XP+8Wra@public.gmane.org>
2017-11-14 23:55 ` Jason Gunthorpe
[not found] ` <20171114235522.GE25894-uk2M96/98Pc@public.gmane.org>
2017-11-15 19:20 ` Ruhl, Michael J
2017-11-14 16:44 ` [PATCH v3 4/4] ibacm: Use MONOTONIC time base to avoid timer expiration issues Michael J. Ruhl
[not found] ` <20171114164352.24557.86825.stgit-K+u1se/DcYrLESAwzcoQNrvm/XP+8Wra@public.gmane.org>
2017-11-14 23:56 ` Jason Gunthorpe [this message]
2017-11-14 18:46 ` [PATCH v3 0/4] ibacm: acmp retry issues Leon Romanovsky
[not found] ` <20171114184603.GG18825-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-11-14 19:10 ` Ruhl, Michael J
[not found] ` <14063C7AD467DE4B82DEDB5C278E86639F0C279D-AtyAts71sc88Ug9VwtkbtrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-11-14 19:40 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114235625.GF25894@ziepe.ca \
--to=jgg-uk2m96/98pc@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=michael.j.ruhl-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox