public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Bryan Tan <bryantan-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
Cc: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	RDMA mailing list
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Benjamin Drung
	<benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
Subject: Re: vmw_pvrdma: Add SRQ support - broke rdma-core
Date: Tue, 14 Nov 2017 20:15:26 -0700	[thread overview]
Message-ID: <20171115031526.GJ25894@ziepe.ca> (raw)
In-Reply-To: <20171115024924.GA23574-qXbCdz4EeRo1jLI2hToXVI42T8aCTgcwy4vvyvUx+exJXi8ZT2ovy+oDBWuYMCC/JZORHMmSJCU@public.gmane.org>

On Tue, Nov 14, 2017 at 06:49:25PM -0800, Bryan Tan wrote:

> Thanks for your suggestion, Jason. I've opened up a new pull request
> that includes the original commit for SRQ support that has been
> reverted, along with the one line change you suggested. Let me know if
> you prefer something different. I've run the travis build on kernels
> both with and without the new ABI header as well.

You should swap the order of the two patches and move the change of
buildlib/fixup-include/rdma-vmw_pvrdma-abi.h to the other patch.

Then the description of the abi.h patch would just be:

'Update rdma-core to the latest kernel pvrdma-abi.h header'

Then everything is more self contained.

You can do this and force push a update to your PR.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-11-15  3:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-14  8:51 vmw_pvrdma: Add SRQ support - broke rdma-core Leon Romanovsky
     [not found] ` <20171114085143.GS18825-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-11-14 18:27   ` Leon Romanovsky
     [not found]     ` <20171114182720.GC18825-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-11-14 19:00       ` Leon Romanovsky
     [not found]         ` <20171114190029.GI18825-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-11-14 19:25           ` Bryan Tan
     [not found]             ` <20171114192510.GA6083-qXbCdz4EeRo1jLI2hToXVI42T8aCTgcwy4vvyvUx+exJXi8ZT2ovy+oDBWuYMCC/JZORHMmSJCU@public.gmane.org>
2017-11-14 19:28               ` Jason Gunthorpe
     [not found]                 ` <20171114192858.GM4263-uk2M96/98Pc@public.gmane.org>
2017-11-15  2:49                   ` Bryan Tan
     [not found]                     ` <20171115024924.GA23574-qXbCdz4EeRo1jLI2hToXVI42T8aCTgcwy4vvyvUx+exJXi8ZT2ovy+oDBWuYMCC/JZORHMmSJCU@public.gmane.org>
2017-11-15  3:15                       ` Jason Gunthorpe [this message]
     [not found]                         ` <20171115031526.GJ25894-uk2M96/98Pc@public.gmane.org>
2017-11-15 22:10                           ` Bryan Tan
     [not found]                             ` <20171115221052.GA16946-qXbCdz4EeRo1jLI2hToXVI42T8aCTgcwy4vvyvUx+exJXi8ZT2ovy+oDBWuYMCC/JZORHMmSJCU@public.gmane.org>
2017-11-16  5:21                               ` Leon Romanovsky
     [not found]                                 ` <20171116052119.GF18825-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-11-16 18:54                                   ` Bryan Tan
     [not found]                                     ` <20171116185450.GB16946-qXbCdz4EeRo1jLI2hToXVI42T8aCTgcwy4vvyvUx+exJXi8ZT2ovy+oDBWuYMCC/JZORHMmSJCU@public.gmane.org>
2017-11-17 23:37                                       ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171115031526.GJ25894@ziepe.ca \
    --to=jgg-uk2m96/98pc@public.gmane.org \
    --cc=benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org \
    --cc=bryantan-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox