From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bryan Tan Subject: Re: vmw_pvrdma: Add SRQ support - broke rdma-core Date: Wed, 15 Nov 2017 14:10:54 -0800 Message-ID: <20171115221052.GA16946@bryantan-devbox.prom.eng.vmware.com.prom.eng.vmware.com> References: <20171114085143.GS18825@mtr-leonro.local> <20171114182720.GC18825@mtr-leonro.local> <20171114190029.GI18825@mtr-leonro.local> <20171114192510.GA6083@bryantan-devbox.prom.eng.vmware.com.prom.eng.vmware.com> <20171114192858.GM4263@ziepe.ca> <20171115024924.GA23574@bryantan-devbox.prom.eng.vmware.com.prom.eng.vmware.com> <20171115031526.GJ25894@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20171115031526.GJ25894-uk2M96/98Pc@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe Cc: Leon Romanovsky , RDMA mailing list , Doug Ledford , Benjamin Drung List-Id: linux-rdma@vger.kernel.org On Tue, Nov 14, 2017 at 08:15:26PM -0700, Jason Gunthorpe wrote: > On Tue, Nov 14, 2017 at 06:49:25PM -0800, Bryan Tan wrote: > > > Thanks for your suggestion, Jason. I've opened up a new pull request > > that includes the original commit for SRQ support that has been > > reverted, along with the one line change you suggested. Let me know if > > you prefer something different. I've run the travis build on kernels > > both with and without the new ABI header as well. > > You should swap the order of the two patches and move the change of > buildlib/fixup-include/rdma-vmw_pvrdma-abi.h to the other patch. > > Then the description of the abi.h patch would just be: > > 'Update rdma-core to the latest kernel pvrdma-abi.h header' > > Then everything is more self contained. > > You can do this and force push a update to your PR. Got it, I've done a force push with the new commits. There were two other items that were in the kernel ABI header and not in the fixup-include header, so I've also fixed that. Unfortunately, I also missed adding the macro I am testing for in RDMA_LinuxHeaders.cmake in the kernel ABI header ): so I sent out a patch to fix that. This should not be a problem, as the test for PVRDMA_UAR_SRQ_OFFSET will make sure we use the header from fixup-include for now, until the kernel patch is accepted. Going forward, I'll copy the ABI header file to make sure they are synced up and I don't make this mistake again. Thanks! Bryan > > Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html