From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Cc: linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Subject: Re: [PATCH v3 2/3] nvme-rdma: don't complete requests before a send work request has completed
Date: Mon, 20 Nov 2017 12:19:24 +0100 [thread overview]
Message-ID: <20171120111924.GA32087@lst.de> (raw)
In-Reply-To: <20171120105324.GA31524-jcswGhMUV9g@public.gmane.org>
On Mon, Nov 20, 2017 at 11:53:24AM +0100, Christoph Hellwig wrote:
> > + req->cqe.status = cqe->status;
> > + req->cqe.result = cqe->result;
>
> I think we'll need to do a memcpy of the whole CQE here.
Or we could just store the status and results fields in the
nvme_rdma_request.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-20 11:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 10:41 [PATCH v3 0/3] Fix request completion holes Sagi Grimberg
[not found] ` <20171120104156.31344-1-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-11-20 10:41 ` [PATCH v3 1/3] nvme-rdma: don't suppress send completions Sagi Grimberg
2017-11-20 10:41 ` [PATCH v3 2/3] nvme-rdma: don't complete requests before a send work request has completed Sagi Grimberg
[not found] ` <20171120104156.31344-3-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-11-20 10:53 ` Christoph Hellwig
[not found] ` <20171120105324.GA31524-jcswGhMUV9g@public.gmane.org>
2017-11-20 11:19 ` Christoph Hellwig [this message]
2017-11-20 10:41 ` [PATCH v3 3/3] nvme-rdma: wait for local invalidation before completing a request Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120111924.GA32087@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).