From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Lijun Ou <oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH rdma-core 1/2] libhns: Make the provider sparse clean
Date: Mon, 20 Nov 2017 11:52:32 -0700 [thread overview]
Message-ID: <20171120185232.GF29075@ziepe.ca> (raw)
In-Reply-To: <1511000496-181604-2-git-send-email-oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On Sat, Nov 18, 2017 at 06:21:35PM +0800, Lijun Ou wrote:
> struct hns_roce_v2_cqe {
> - unsigned int byte_4;
> - unsigned int rkey_immtdata;
> - unsigned int byte_12;
> - unsigned int byte_16;
> - unsigned int byte_cnt;
> - unsigned int smac;
> - unsigned int byte_28;
> - unsigned int byte_32;
> + __le32 byte_4;
> + union {
> + __le32 rkey;
> + __be32 immtdata;
> + };
Yes, that looks exactly right.
Reviewed-by: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-20 18:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-18 10:21 [PATCH rdma-core 0/2] Fixes for hip8 libhns Lijun Ou
[not found] ` <1511000496-181604-1-git-send-email-oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-11-18 10:21 ` [PATCH rdma-core 1/2] libhns: Make the provider sparse clean Lijun Ou
[not found] ` <1511000496-181604-2-git-send-email-oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-11-20 18:52 ` Jason Gunthorpe [this message]
2017-11-18 10:21 ` [PATCH rdma-core 2/2] libhns: Filter for zero length of sge in hip08 userspace Lijun Ou
2017-11-20 8:30 ` [PATCH rdma-core 0/2] Fixes for hip8 libhns Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120185232.GF29075@ziepe.ca \
--to=jgg-uk2m96/98pc@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).