From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
noaos-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH rdma-core 2/2] mlx5: Allow creation of a Multi-Packet RQ using direct verbs
Date: Mon, 20 Nov 2017 12:04:34 -0700 [thread overview]
Message-ID: <20171120190434.GG29075@ziepe.ca> (raw)
In-Reply-To: <1511119268-5934-3-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
On Sun, Nov 19, 2017 at 09:21:08PM +0200, Yishai Hadas wrote:
> + if (mlx5wq_attr) {
> + if (mlx5wq_attr->comp_mask & ~(MLX5DV_WQ_INIT_ATTR_MASK_RESERVED - 1))
> + return -EINVAL;
Please no. Check that only the bits this function actually supports
are set and get rid of _RESERVED.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-20 19:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-19 19:21 [PATCH rdma-core 0/2] mlx5: Add striding RQ support via the DV API Yishai Hadas
[not found] ` <1511119268-5934-1-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-11-19 19:21 ` [PATCH rdma-core 1/2] mlx5: Report Multi-Packet RQ capabilities through mlx5 direct verbs Yishai Hadas
2017-11-19 19:21 ` [PATCH rdma-core 2/2] mlx5: Allow creation of a Multi-Packet RQ using " Yishai Hadas
[not found] ` <1511119268-5934-3-git-send-email-yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-11-20 19:04 ` Jason Gunthorpe [this message]
[not found] ` <20171120190434.GG29075-uk2M96/98Pc@public.gmane.org>
2017-11-21 6:05 ` Leon Romanovsky
[not found] ` <20171121060504.GO18825-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-11-21 8:21 ` Yishai Hadas
2017-11-21 12:01 ` Yishai Hadas
[not found] ` <f164e1c4-e3b2-8778-448e-1fb0da6e6dc1-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2017-11-21 15:53 ` Jason Gunthorpe
[not found] ` <20171121155304.GA18272-uk2M96/98Pc@public.gmane.org>
2017-11-21 17:17 ` Yishai Hadas
[not found] ` <63dd046b-ac6d-3ff2-0dc5-82d29bac9393-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2017-11-21 17:20 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120190434.GG29075@ziepe.ca \
--to=jgg-uk2m96/98pc@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=noaos-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox