From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Lijun Ou <oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH rdma-core] libhns: Add rereg mr interface in userspace
Date: Tue, 21 Nov 2017 08:18:08 -0700 [thread overview]
Message-ID: <20171121151808.GT29075@ziepe.ca> (raw)
In-Reply-To: <20171121135310.GV18825-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
On Tue, Nov 21, 2017 at 03:53:10PM +0200, Leon Romanovsky wrote:
> > + if (flags & IBV_REREG_MR_KEEP_VALID)
> > + return ENOTSUP;
>
> You need to write the supported flags here, so the people will
> be able to extend ibv_rereg_mr_flags without worries about your driver.
And doesn't the kernel check flags anyhow? Why do you need to also
check it in userspace?
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-21 15:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 12:20 [PATCH rdma-core] libhns: Add rereg mr interface in userspace Lijun Ou
[not found] ` <1511266846-137693-1-git-send-email-oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-11-21 13:53 ` Leon Romanovsky
[not found] ` <20171121135310.GV18825-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-11-21 15:18 ` Jason Gunthorpe [this message]
2017-11-24 8:38 ` oulijun
[not found] ` <facbc654-30ad-1bb7-f066-6dff2d5deaca-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-11-24 16:03 ` Jason Gunthorpe
[not found] ` <20171124160347.GA3552-uk2M96/98Pc@public.gmane.org>
2017-11-25 1:23 ` oulijun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121151808.GT29075@ziepe.ca \
--to=jgg-uk2m96/98pc@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox