From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Cc: linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
Max Gurtuvoy <maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH v5 2/4] nvme-rdma: don't complete requests before a send work request has completed
Date: Thu, 23 Nov 2017 09:08:58 +0100 [thread overview]
Message-ID: <20171123080858.GA20524@lst.de> (raw)
In-Reply-To: <20171122185838.28855-3-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
> static void nvme_rdma_send_done(struct ib_cq *cq, struct ib_wc *wc)
> {
> - if (unlikely(wc->status != IB_WC_SUCCESS))
> + struct nvme_rdma_qe *qe;
> + struct nvme_rdma_request *req;
> + struct request *rq;
> +
> + if (unlikely(wc->status != IB_WC_SUCCESS)) {
> nvme_rdma_wr_error(cq, wc, "SEND");
> + return;
> + }
> +
> + qe = container_of(wc->wr_cqe, struct nvme_rdma_qe, cqe);
> + req = container_of(qe, struct nvme_rdma_request, sqe);
> + rq = blk_mq_rq_from_pdu(req);
This add least needs a comment that this is for the AEN request.
Or we'll just use a separate completion handler for the AEN. In fact
it seems to me that we might want to just stop using nvme_rdma_post_send
for the AEN request and just open code the sending in both callers.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-23 8:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 18:58 [PATCH v5 0/4] Fix request completion holes Sagi Grimberg
[not found] ` <20171122185838.28855-1-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-11-22 18:58 ` [PATCH v5 1/4] nvme-rdma: don't suppress send completions Sagi Grimberg
2017-11-22 18:58 ` [PATCH v5 2/4] nvme-rdma: don't complete requests before a send work request has completed Sagi Grimberg
[not found] ` <20171122185838.28855-3-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-11-23 8:08 ` Christoph Hellwig [this message]
2017-11-22 18:58 ` [PATCH v5 3/4] nvme-rdma: wait for local invalidation before completing a request Sagi Grimberg
2017-11-22 18:58 ` [PATCH v5 4/4] nvme-rdma: Check remotely invalidated rkey matches our expected rkey Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171123080858.GA20524@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).