From: Greg KH <greg@kroah.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Mike Marciniszyn <mike.marciniszyn@intel.com>,
stable@vger.kernel.org, linux-rdma@vger.kernel.org,
stable-commits@vger.kernel.org
Subject: Re: [PATCH 2/2] IB/hfi1: Do not warn on lid conversions for OPA
Date: Mon, 4 Dec 2017 13:13:33 +0100 [thread overview]
Message-ID: <20171204121333.GC18589@kroah.com> (raw)
In-Reply-To: <20171129184324.GF4011@ziepe.ca>
On Wed, Nov 29, 2017 at 11:43:24AM -0700, Jason Gunthorpe wrote:
> On Wed, Nov 29, 2017 at 07:59:49AM -0500, Mike Marciniszyn wrote:
> > From: Don Hiatt <don.hiatt@intel.com>
> >
> > Upstream commit 4988be5813ff2afdc0d8bfa315ef34a577d3efbf.
> >
> > On OPA devices opa_local_smp_check will receive 32Bit LIDs when the LID
> > is Extended. In such cases, it is okay to lose the upper 16 bits of the
> > LID as this information is obtained elsewhere. Do not issue a warning
> > when calling ib_lid_cpu16() in this case by masking out the upper 16Bits.
>
> The concept for the 32 bit lids was to keep it 32 bit inside the
> kernel, ingress_key_table_fail puts the lid into
> err_info_constraint.slid which is already 32 bits, so this cannot be
> the right place for this.
>
> These truncations should only appear at the uapi boundary.
Ok, but that's what the change in Linus's tree does. If you object to
that, please fix it there :)
thanks,
greg k-h
next prev parent reply other threads:[~2017-12-04 12:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 12:59 [PATCH 1/2] IB/core: Do not warn on lid conversions for OPA Mike Marciniszyn
[not found] ` <20171129125943.31113.29038.stgit-K+u1se/DcYrLESAwzcoQNrvm/XP+8Wra@public.gmane.org>
2017-11-29 12:59 ` [PATCH 2/2] IB/hfi1: " Mike Marciniszyn
[not found] ` <20171129125948.31113.59826.stgit-K+u1se/DcYrLESAwzcoQNrvm/XP+8Wra@public.gmane.org>
2017-11-29 18:43 ` Jason Gunthorpe
2017-12-04 12:13 ` Greg KH [this message]
2017-12-04 17:28 ` Don Hiatt
[not found] ` <caedb116-7e5a-5461-0c72-500b56d5b6be-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-12-04 18:04 ` Jason Gunthorpe
2017-11-29 18:17 ` [PATCH 1/2] IB/core: " Parav Pandit
[not found] ` <VI1PR0502MB30086F9ADA549CD6C6F550AFD13B0-o1MPJYiShExKsLr+rGaxW8DSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2017-12-04 12:11 ` Greg KH
[not found] ` <20171204121152.GB18589-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-12-04 17:28 ` Don Hiatt
2017-12-05 4:04 ` Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204121333.GC18589@kroah.com \
--to=greg@kroah.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).