[PATCH] RDMA/bnxt_re: Remove redundant bnxt_qplib_disable_nq() call

[PATCH] RDMA/bnxt_re: Remove redundant bnxt_qplib_disable_nq() call

[Arvind Yadav]

The bnxt_qplib_disable_nq() call is redundant as it occurs
after 'goto fail' and hence it called twice. Remove it.

Signed-off-by: Arvind Yadav <arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 drivers/infiniband/hw/bnxt_re/qplib_fp.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/hw/bnxt_re/qplib_fp.c b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
index e8afc47..bb7cf5e 100644
--- a/drivers/infiniband/hw/bnxt_re/qplib_fp.c
+++ b/drivers/infiniband/hw/bnxt_re/qplib_fp.c
@@ -409,7 +409,6 @@ int bnxt_qplib_enable_nq(struct pci_dev *pdev, struct bnxt_qplib_nq *nq,
 	if (rc) {
 		dev_err(&nq->pdev->dev,
 			"Failed to request IRQ for NQ: %#x", rc);
-		bnxt_qplib_disable_nq(nq);
 		goto fail;
 	}
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: RDMA/bnxt_re: Remove redundant bnxt_qplib_disable_nq() call

[Jason Gunthorpe]

On Tue, Nov 14, 2017 at 06:20:56PM +0530, Arvind Yadav wrote:
> The bnxt_qplib_disable_nq() call is redundant as it occurs
> after 'goto fail' and hence it called twice. Remove it.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>  drivers/infiniband/hw/bnxt_re/qplib_fp.c | 1 -
>  1 file changed, 1 deletion(-)

Applied to for-next, thanks

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: RDMA/bnxt_re: Remove redundant bnxt_qplib_disable_nq() call

[Devesh Sharma]

However delayed ack but still..thanks for supplying this fix.

Acked-by: Devesh Sharma <devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>


On Wed, Dec 13, 2017 at 11:07 PM, Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org> wrote:
> On Tue, Nov 14, 2017 at 06:20:56PM +0530, Arvind Yadav wrote:
>> The bnxt_qplib_disable_nq() call is redundant as it occurs
>> after 'goto fail' and hence it called twice. Remove it.
>>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>  drivers/infiniband/hw/bnxt_re/qplib_fp.c | 1 -
>>  1 file changed, 1 deletion(-)
>
> Applied to for-next, thanks
>
> Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: RDMA/bnxt_re: Remove redundant bnxt_qplib_disable_nq() call

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]

On Tue, Dec 19, 2017 at 04:40:42PM +0530, Devesh Sharma wrote:
> However delayed ack but still..thanks for supplying this fix.
>
> Acked-by: Devesh Sharma <devesh.sharma-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
>

Devesh,

What should we do in order to stop you to answer in top-posting format?

Thanks


>
> On Wed, Dec 13, 2017 at 11:07 PM, Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org> wrote:
> > On Tue, Nov 14, 2017 at 06:20:56PM +0530, Arvind Yadav wrote:
> >> The bnxt_qplib_disable_nq() call is redundant as it occurs
> >> after 'goto fail' and hence it called twice. Remove it.
> >>
> >> Signed-off-by: Arvind Yadav <arvind.yadav.cs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> >>  drivers/infiniband/hw/bnxt_re/qplib_fp.c | 1 -
> >>  1 file changed, 1 deletion(-)
> >
> > Applied to for-next, thanks
> >
> > Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]