From: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Shiraz Saleem <shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
jgg-uk2M96/98Pc@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH rdma-next 1/2] nes: Change accelerated flag to bool
Date: Mon, 18 Dec 2017 10:20:37 +0200 [thread overview]
Message-ID: <20171218082036.GA2632@yuvallap> (raw)
In-Reply-To: <20171217182139.17096-2-shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Sun, Dec 17, 2017 at 12:21:38PM -0600, Shiraz Saleem wrote:
> The accelerated flag only utilizes two values: 0 and 1.
> Modify accelerated flag in struct nes_cm_node to bool.
>
> Signed-off-by: Shiraz Saleem <shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
> drivers/infiniband/hw/nes/nes_cm.c | 2 +-
> drivers/infiniband/hw/nes/nes_cm.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c
> index c56ca2a..6cdfbf8 100644
> --- a/drivers/infiniband/hw/nes/nes_cm.c
> +++ b/drivers/infiniband/hw/nes/nes_cm.c
> @@ -1365,7 +1365,7 @@ static int mini_cm_del_listen(struct nes_cm_core *cm_core,
> static inline int mini_cm_accelerated(struct nes_cm_core *cm_core,
> struct nes_cm_node *cm_node)
> {
> - cm_node->accelerated = 1;
> + cm_node->accelerated = true;
>
> if (cm_node->accept_pend) {
> BUG_ON(!cm_node->listener);
> diff --git a/drivers/infiniband/hw/nes/nes_cm.h b/drivers/infiniband/hw/nes/nes_cm.h
> index d827d03..d462797 100644
> --- a/drivers/infiniband/hw/nes/nes_cm.h
> +++ b/drivers/infiniband/hw/nes/nes_cm.h
> @@ -341,7 +341,7 @@ struct nes_cm_node {
> u16 mpa_frame_size;
> struct iw_cm_id *cm_id;
> struct list_head list;
> - int accelerated;
> + bool accelerated;
> struct nes_cm_listener *listener;
> enum nes_cm_conn_type conn_type;
> struct nes_vnic *nesvnic;
> --
Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> 2.8.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-12-18 8:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-17 18:21 [PATCH rdma-next 0/2] Minor cleanup in i40iw/nes Shiraz Saleem
[not found] ` <20171217182139.17096-1-shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-12-17 18:21 ` [PATCH rdma-next 1/2] nes: Change accelerated flag to bool Shiraz Saleem
[not found] ` <20171217182139.17096-2-shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-12-18 8:20 ` Yuval Shaia [this message]
2017-12-22 23:44 ` Jason Gunthorpe
2017-12-17 18:21 ` [PATCH rdma-next 2/2] i40iw: " Shiraz Saleem
[not found] ` <20171217182139.17096-3-shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-12-18 8:20 ` Yuval Shaia
2017-12-28 4:47 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218082036.GA2632@yuvallap \
--to=yuval.shaia-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=jgg-uk2M96/98Pc@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).