From: Potnuri Bharat Teja <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
To: Chelsio Cudbg
<chelsiocudbg-YEAOTlfEoH4oZ4o0MQTwmEh/o/VBkw4H@public.gmane.org>
Cc: "dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
SWise OGC
<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Subject: Re: [PATCH for-next] iw_cxgb4: Change error/warn prints to pr_debug
Date: Tue, 19 Dec 2017 15:44:30 +0530 [thread overview]
Message-ID: <20171219101429.GA6736@chelsio.com> (raw)
In-Reply-To: <1513678108-6634-1-git-send-email-chelsiocudbg-KJX8L1YACloTKYOLMXNBRxrm3jAUxWOA@public.gmane.org>
Sorry, Please ignore this sent with wrong username.
Shall send a proper one.
-Bharat
On Tuesday, December 12/19/17, 2017 at 15:38:28 +0530, Chelsio Cudbg wrote:
> From: Potnuri Bharat Teja <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
>
> These prints not neccesarily mean error, so changing them to debug.
> Redifining pr_fmt to print the kernel module name, prints the module
> name twice when +m flag of pr_debug is enabled, hence removing the
> pr_fmt redefinition.
>
> Signed-off-by: Potnuri Bharat Teja <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> ---
> drivers/infiniband/hw/cxgb4/cm.c | 4 ++--
> drivers/infiniband/hw/cxgb4/ev.c | 2 +-
> drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 6 ------
> 3 files changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index 21db3b48a617..eecdfb0c6be6 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -3567,8 +3567,8 @@ int c4iw_ep_disconnect(struct c4iw_ep *ep, int abrupt, gfp_t gfp)
> case MORIBUND:
> case ABORTING:
> case DEAD:
> - pr_info("%s ignoring disconnect ep %p state %u\n",
> - __func__, ep, ep->com.state);
> + pr_debug("ignoring disconnect ep %p state %u\n",
> + ep, ep->com.state);
> break;
> default:
> WARN_ONCE(1, "Bad endpoint state %u\n", ep->com.state);
> diff --git a/drivers/infiniband/hw/cxgb4/ev.c b/drivers/infiniband/hw/cxgb4/ev.c
> index a252d5c40ae3..3e9d8b277ab9 100644
> --- a/drivers/infiniband/hw/cxgb4/ev.c
> +++ b/drivers/infiniband/hw/cxgb4/ev.c
> @@ -236,7 +236,7 @@ int c4iw_ev_handler(struct c4iw_dev *dev, u32 qid)
> if (atomic_dec_and_test(&chp->refcnt))
> wake_up(&chp->wait);
> } else {
> - pr_warn("%s unknown cqid 0x%x\n", __func__, qid);
> + pr_debug("unknown cqid 0x%x\n", qid);
> spin_unlock_irqrestore(&dev->lock, flag);
> }
> return 0;
> diff --git a/drivers/infiniband/hw/cxgb4/iw_cxgb4.h b/drivers/infiniband/hw/cxgb4/iw_cxgb4.h
> index 470f97a79ebb..7d6ec29ec9d7 100644
> --- a/drivers/infiniband/hw/cxgb4/iw_cxgb4.h
> +++ b/drivers/infiniband/hw/cxgb4/iw_cxgb4.h
> @@ -64,12 +64,6 @@
> #define DRV_NAME "iw_cxgb4"
> #define MOD DRV_NAME ":"
>
> -#ifdef pr_fmt
> -#undef pr_fmt
> -#endif
> -
> -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> -
> #include "t4.h"
>
> #define PBL_OFF(rdev_p, a) ((a) - (rdev_p)->lldi.vr->pbl.start)
> --
> 2.5.3
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-12-19 10:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 10:08 [PATCH for-next] iw_cxgb4: Change error/warn prints to pr_debug Chelsio Cudbg
[not found] ` <1513678108-6634-1-git-send-email-chelsiocudbg-KJX8L1YACloTKYOLMXNBRxrm3jAUxWOA@public.gmane.org>
2017-12-19 10:14 ` Potnuri Bharat Teja [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-19 10:44 Potnuri Bharat Teja
[not found] ` <1513680256-8153-1-git-send-email-bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2017-12-19 20:16 ` Jason Gunthorpe
[not found] ` <20171219201639.GA14814-uk2M96/98Pc@public.gmane.org>
2017-12-19 21:12 ` Steve Wise
2017-12-19 22:23 ` Jason Gunthorpe
[not found] ` <20171219222300.GH14814-uk2M96/98Pc@public.gmane.org>
2017-12-19 22:32 ` Steve Wise
2017-12-22 17:32 ` Jason Gunthorpe
[not found] ` <20171222173207.GF30884-uk2M96/98Pc@public.gmane.org>
2017-12-29 6:43 ` Potnuri Bharat Teja
[not found] ` <20171229064337.GA15043-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2017-12-29 18:09 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219101429.GA6736@chelsio.com \
--to=bharat-ut6up61k2wzbdgjk7y7tuq@public.gmane.org \
--cc=chelsiocudbg-YEAOTlfEoH4oZ4o0MQTwmEh/o/VBkw4H@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox