public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Yixian Liu <liuyixian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: jgg-uk2M96/98Pc@public.gmane.org,
	dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH for-next 1/2] RDMA/hns: Add detailed comments for mb() call
Date: Tue, 26 Dec 2017 09:37:39 +0200	[thread overview]
Message-ID: <20171226073739.GA10734@mtr-leonro.local> (raw)
In-Reply-To: <1514209039-9388-2-git-send-email-liuyixian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

On Mon, Dec 25, 2017 at 09:37:18PM +0800, Yixian Liu wrote:
> This patch adds more detailed comments when we call the
> memory barrier function, such as rmb, wmb and mb. Three
> mb() callers are deleted since they are unnecessary.
>
> Signed-off-by: Yixian Liu <liuyixian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Lijun Ou <oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Wei Hu (Xavier) <xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 19 ++++++++++++++-----
>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 22 +++++++++++-----------
>  2 files changed, 25 insertions(+), 16 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2017-12-26  7:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-25 13:37 [PATCH for-next 0/2] Bugfixes for eq support in hns Yixian Liu
     [not found] ` <1514209039-9388-1-git-send-email-liuyixian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-12-25 13:37   ` [PATCH for-next 1/2] RDMA/hns: Add detailed comments for mb() call Yixian Liu
     [not found]     ` <1514209039-9388-2-git-send-email-liuyixian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-12-26  7:37       ` Leon Romanovsky [this message]
2017-12-25 13:37   ` [PATCH for-next 2/2] RDMA/hns: Fix alignment problem of the doorbell Yixian Liu
     [not found]     ` <1514209039-9388-3-git-send-email-liuyixian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-12-26  8:15       ` Leon Romanovsky
     [not found]         ` <20171226081526.GB10734-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-12-27 10:01           ` Liuyixian (Eason)
     [not found]             ` <6f657295-ab91-a940-c1d8-8d85dcedb4ea-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-12-27 16:44               ` Jason Gunthorpe
     [not found]                 ` <20171227164407.GB25436-uk2M96/98Pc@public.gmane.org>
2017-12-28  6:48                   ` Liuyixian (Eason)
     [not found]                     ` <2a0a56fb-1ec8-dfc9-3c29-c9bae7bd9bae-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2017-12-28  8:31                       ` Liuyixian (Eason)
2017-12-28 16:00                       ` Jason Gunthorpe
2017-12-27 17:40       ` Ruhl, Michael J
     [not found]         ` <14063C7AD467DE4B82DEDB5C278E86639F0E6137-AtyAts71sc88Ug9VwtkbtrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-12-28  6:51           ` Liuyixian (Eason)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171226073739.GA10734@mtr-leonro.local \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=jgg-uk2M96/98Pc@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=liuyixian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox