public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Shiraz Saleem <shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH rdma-next 0/9] i40iw updates for 4.16
Date: Wed, 27 Dec 2017 07:58:01 -0700	[thread overview]
Message-ID: <20171227145801.GA25436@ziepe.ca> (raw)
In-Reply-To: <20171223162708.GA13848-GOXS9JX10wfOxmVO0tvppfooFf0ArEBIu+b9c/7xato@public.gmane.org>

On Sat, Dec 23, 2017 at 10:27:08AM -0600, Shiraz Saleem wrote:
> On Fri, Dec 22, 2017 at 04:36:50PM -0700, Jason Gunthorpe wrote:
> > On Fri, Dec 22, 2017 at 09:46:53AM -0600, Shiraz Saleem wrote:
> > > Hi Doug/Jason,
> > >  
> > > This patch set includes bug fixes, code refactoring, a new netdev
> > > event notifier and misc. improvements. Please consider it for 4.16.
> > 
> > I took this from the v0 series and manually fixed the const myself.
> > 
> > I also fixed the checkpatch long line warnings, so please watch out
> > for things like that.
> > 
> We try to keep our line length < 100 in general. 
> Are we enforcing the 80 char line length limit? 

It is the kernel style, and the goal is to have all code follow the
major tenants of it.

Linus has come out in the past against > 80 lines as a metric of
too much complexity.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-12-27 14:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-22 15:46 [PATCH rdma-next 0/9] i40iw updates for 4.16 Shiraz Saleem
     [not found] ` <20171222154702.12632-1-shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-12-22 15:46   ` [PATCH rdma-next 1/9] i40iw: Set MAX_IRD_SIZE to 64 Shiraz Saleem
2017-12-22 15:46   ` [PATCH rdma-next 2/9] i40iw: Use utility function roundup_pow_of_two() Shiraz Saleem
2017-12-22 15:46   ` [PATCH rdma-next 3/9] i40iw: Correct Q1/XF object count equation Shiraz Saleem
2017-12-22 15:46   ` [PATCH rdma-next 4/9] i40iw: Add notifier for network device events Shiraz Saleem
2017-12-22 15:46   ` [PATCH rdma-next 5/9] i40iw: Selectively teardown QPs on IP addr change event Shiraz Saleem
2017-12-22 15:46   ` [PATCH rdma-next 6/9] i40iw: Fix sequence number for the first partial FPDU Shiraz Saleem
2017-12-22 15:47   ` [PATCH rdma-next 7/9] i40iw: Ignore LLP_DOUBT_REACHABILITY AE Shiraz Saleem
2017-12-22 15:47   ` [PATCH rdma-next 8/9] i40iw: Validate correct IRD/ORD connection parameters Shiraz Saleem
2017-12-22 15:47   ` [PATCH rdma-next 9/9] i40iw: Fix the connection ORD value for loopback Shiraz Saleem
     [not found]     ` <20171222154702.12632-10-shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-12-22 16:10       ` Jason Gunthorpe
     [not found]         ` <20171222161049.GB30884-uk2M96/98Pc@public.gmane.org>
2017-12-22 20:35           ` Saleem, Shiraz
2017-12-22 23:36   ` [PATCH rdma-next 0/9] i40iw updates for 4.16 Jason Gunthorpe
     [not found]     ` <20171222233650.GA17198-uk2M96/98Pc@public.gmane.org>
2017-12-23 16:27       ` Shiraz Saleem
     [not found]         ` <20171223162708.GA13848-GOXS9JX10wfOxmVO0tvppfooFf0ArEBIu+b9c/7xato@public.gmane.org>
2017-12-27 14:58           ` Jason Gunthorpe [this message]
     [not found]             ` <20171227145801.GA25436-uk2M96/98Pc@public.gmane.org>
2017-12-27 16:11               ` Tung, Chien Tin
     [not found]                 ` <748B799B6A00724488C603FD7E5E7EB977BADFAC-XfjTATA9Em864kNsxIetb7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2017-12-27 17:21                   ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171227145801.GA25436@ziepe.ca \
    --to=jgg-uk2m96/98pc@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=e1000-rdma-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=shiraz.saleem-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox