Re: [PATCH for-next 4/4] RDMA/vmw_pvrdma: Remove usage of BIT() from UAPI header

Leon Romanovsky
2017-12-21T13:00:34Z

[-- Attachment #1: Type: text/plain, Size: 1874 bytes --]

On Wed, Dec 20, 2017 at 11:27:28AM -0800, Bryan Tan wrote:
> BIT() should not be used in the UAPI header. Remove it.
>
> Signed-off-by: Bryan Tan <bryantan-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
> ---
> include/uapi/rdma/vmw_pvrdma-abi.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)

IMHO, it should go to -rc.
Doug, Jason?

>
> diff --git a/include/uapi/rdma/vmw_pvrdma-abi.h b/include/uapi/rdma/vmw_pvrdma-abi.h
> index 4007cac..02ca0d0 100644
> --- a/include/uapi/rdma/vmw_pvrdma-abi.h
> +++ b/include/uapi/rdma/vmw_pvrdma-abi.h
> @@ -52,14 +52,14 @@
> #define PVRDMA_UVERBS_ABI_VERSION 3 /* ABI Version. */
> #define PVRDMA_UAR_HANDLE_MASK 0x00FFFFFF /* Bottom 24 bits. */
> #define PVRDMA_UAR_QP_OFFSET 0 /* QP doorbell. */
> -#define PVRDMA_UAR_QP_SEND BIT(30) /* Send bit. */
> -#define PVRDMA_UAR_QP_RECV BIT(31) /* Recv bit. */
> +#define PVRDMA_UAR_QP_SEND (1 << 30) /* Send bit. */
> +#define PVRDMA_UAR_QP_RECV (1 << 31) /* Recv bit. */
> #define PVRDMA_UAR_CQ_OFFSET 4 /* CQ doorbell. */
> -#define PVRDMA_UAR_CQ_ARM_SOL BIT(29) /* Arm solicited bit. */
> -#define PVRDMA_UAR_CQ_ARM BIT(30) /* Arm bit. */
> -#define PVRDMA_UAR_CQ_POLL BIT(31) /* Poll bit. */
> +#define PVRDMA_UAR_CQ_ARM_SOL (1 << 29) /* Arm solicited bit. */
> +#define PVRDMA_UAR_CQ_ARM (1 << 30) /* Arm bit. */
> +#define PVRDMA_UAR_CQ_POLL (1 << 31) /* Poll bit. */
> #define PVRDMA_UAR_SRQ_OFFSET 8 /* SRQ doorbell. */
> -#define PVRDMA_UAR_SRQ_RECV BIT(30) /* Recv bit. */
> +#define PVRDMA_UAR_SRQ_RECV (1 << 30) /* Recv bit. */
>
> enum pvrdma_wr_opcode {
> PVRDMA_WR_RDMA_WRITE,
> --
> 1.8.5.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]