Re: [PATCH rdma-next 6/6] IB/mlx5: Move locks initialization to the corresponding stage

Jason Gunthorpe
2017-12-28T16:03:10Z

On Thu, Dec 28, 2017 at 09:51:24AM +0200, Mark Bloch wrote:

> Yes, let me explain.
> This entire series aims to allow to turn on/off certain features and to
> group the init/cleanup of those features together.
> If you take that into account, the srcu (which is needed only for ODP)
> needs to be done in the ODP stage, but the issue is that not only ODP code
> uses the srcu, destroy_mkey() will sync on it.

Okay, right, so this series creates the united srcu possibility. The
commit messages are not totally clear..

> So I can move the srcu initialization to INIT, but this way we lose
> context when looking at the ODP stage.

If something is being used by multiple stages then it really seems
like it should be common.

Introducing a function call back just to avoid initing a srcu in
common code for the sole reason of 'keeping like together' seems
like bad taste to me..

Jason