Re: [PATCH rdma-next 6/6] IB/mlx5: Move locks initialization to the corresponding stage

Jason Gunthorpe
2017-12-28T05:35:23Z

On Thu, Dec 28, 2017 at 07:32:59AM +0200, Leon Romanovsky wrote:
> On Wed, Dec 27, 2017 at 10:18:06PM -0700, Jason Gunthorpe wrote:
> > On Sun, Dec 24, 2017 at 02:40:15PM +0200, Leon Romanovsky wrote:
> > > From: Mark Bloch <markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > >
> > > Unconditional locks/list initialization should be done in the INIT stage.
> > > Remove those from the CAPS stage and move them to the proper stage.
> >
> > So why not always initialize the srcu instead of using that wonky
> > callback function?
>
> Maybe, but now, it is out of scope for this series, which more or less
> moves code from one place to another.

So the possibility of an uninited SRCU existed before and this is
fixing a bug? I had the impression this series was introducing that
possibility...

Jason