From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Mark Bloch <markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH rdma-next 6/6] IB/mlx5: Move locks initialization to the corresponding stage
Date: Wed, 27 Dec 2017 22:35:23 -0700 [thread overview]
Message-ID: <20171228053523.GR25436@ziepe.ca> (raw)
In-Reply-To: <20171228053259.GP3494-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
On Thu, Dec 28, 2017 at 07:32:59AM +0200, Leon Romanovsky wrote:
> On Wed, Dec 27, 2017 at 10:18:06PM -0700, Jason Gunthorpe wrote:
> > On Sun, Dec 24, 2017 at 02:40:15PM +0200, Leon Romanovsky wrote:
> > > From: Mark Bloch <markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > >
> > > Unconditional locks/list initialization should be done in the INIT stage.
> > > Remove those from the CAPS stage and move them to the proper stage.
> >
> > So why not always initialize the srcu instead of using that wonky
> > callback function?
>
> Maybe, but now, it is out of scope for this series, which more or less
> moves code from one place to another.
So the possibility of an uninited SRCU existed before and this is
fixing a bug? I had the impression this series was introducing that
possibility...
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-12-28 5:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-24 12:40 [PATCH rdma-next 0/6] mlx5 profile infrastructure to add and remove stages Leon Romanovsky
[not found] ` <20171224124015.31917-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-12-24 12:40 ` [PATCH rdma-next 1/6] IB/mlx5: Create " Leon Romanovsky
[not found] ` <20171224124015.31917-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-12-28 5:13 ` Jason Gunthorpe
2017-12-24 12:40 ` [PATCH rdma-next 2/6] IB/mlx5: Move RoCE/ETH initialization to the corresponding stage Leon Romanovsky
2017-12-24 12:40 ` [PATCH rdma-next 3/6] IB/mlx5: Move ODP " Leon Romanovsky
2017-12-24 12:40 ` [PATCH rdma-next 4/6] IB/mlx5: Move hardware counters " Leon Romanovsky
2017-12-24 12:40 ` [PATCH rdma-next 5/6] IB/mlx5: Move loopback " Leon Romanovsky
2017-12-24 12:40 ` [PATCH rdma-next 6/6] IB/mlx5: Move locks " Leon Romanovsky
[not found] ` <20171224124015.31917-7-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-12-28 5:18 ` Jason Gunthorpe
[not found] ` <20171228051806.GP25436-uk2M96/98Pc@public.gmane.org>
2017-12-28 5:32 ` Leon Romanovsky
[not found] ` <20171228053259.GP3494-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2017-12-28 5:35 ` Jason Gunthorpe [this message]
[not found] ` <20171228053523.GR25436-uk2M96/98Pc@public.gmane.org>
2017-12-28 7:51 ` Mark Bloch
[not found] ` <3ad02325-5244-31c9-eb6d-139a17b064b6-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-12-28 16:03 ` Jason Gunthorpe
[not found] ` <20171228160310.GW25436-uk2M96/98Pc@public.gmane.org>
2017-12-28 17:10 ` Mark Bloch
[not found] ` <9f8a7042-7c6a-9929-fa10-0edf5c6e366e-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-12-28 17:14 ` Jason Gunthorpe
[not found] ` <20171228171428.GA25436-uk2M96/98Pc@public.gmane.org>
2017-12-28 17:22 ` Mark Bloch
[not found] ` <70dcf1fa-fd00-7288-3a59-0d61e62e0043-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-12-28 17:45 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171228053523.GR25436@ziepe.ca \
--to=jgg-uk2m96/98pc@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox