From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-next 6/6] IB/mlx5: Move locks initialization to the corresponding stage Date: Wed, 27 Dec 2017 22:35:23 -0700 Message-ID: <20171228053523.GR25436@ziepe.ca> References: <20171224124015.31917-1-leon@kernel.org> <20171224124015.31917-7-leon@kernel.org> <20171228051806.GP25436@ziepe.ca> <20171228053259.GP3494@mtr-leonro.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20171228053259.GP3494-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Bloch List-Id: linux-rdma@vger.kernel.org On Thu, Dec 28, 2017 at 07:32:59AM +0200, Leon Romanovsky wrote: > On Wed, Dec 27, 2017 at 10:18:06PM -0700, Jason Gunthorpe wrote: > > On Sun, Dec 24, 2017 at 02:40:15PM +0200, Leon Romanovsky wrote: > > > From: Mark Bloch > > > > > > Unconditional locks/list initialization should be done in the INIT stage. > > > Remove those from the CAPS stage and move them to the proper stage. > > > > So why not always initialize the srcu instead of using that wonky > > callback function? > > Maybe, but now, it is out of scope for this series, which more or less > moves code from one place to another. So the possibility of an uninited SRCU existed before and this is fixing a bug? I had the impression this series was introducing that possibility... Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html