From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-next 6/6] IB/mlx5: Move locks initialization to the corresponding stage Date: Thu, 28 Dec 2017 09:03:10 -0700 Message-ID: <20171228160310.GW25436@ziepe.ca> References: <20171224124015.31917-1-leon@kernel.org> <20171224124015.31917-7-leon@kernel.org> <20171228051806.GP25436@ziepe.ca> <20171228053259.GP3494@mtr-leonro.local> <20171228053523.GR25436@ziepe.ca> <3ad02325-5244-31c9-eb6d-139a17b064b6@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <3ad02325-5244-31c9-eb6d-139a17b064b6-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Bloch Cc: Leon Romanovsky , Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Thu, Dec 28, 2017 at 09:51:24AM +0200, Mark Bloch wrote: > Yes, let me explain. > This entire series aims to allow to turn on/off certain features and to > group the init/cleanup of those features together. > If you take that into account, the srcu (which is needed only for ODP) > needs to be done in the ODP stage, but the issue is that not only ODP code > uses the srcu, destroy_mkey() will sync on it. Okay, right, so this series creates the united srcu possibility. The commit messages are not totally clear.. > So I can move the srcu initialization to INIT, but this way we lose > context when looking at the ODP stage. If something is being used by multiple stages then it really seems like it should be common. Introducing a function call back just to avoid initing a srcu in common code for the sole reason of 'keeping like together' seems like bad taste to me.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html