From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH V2 for-next 1/6] RDMA/hns: Add rq inline data support for hip08 RoCE Date: Thu, 28 Dec 2017 14:22:17 -0700 Message-ID: <20171228212217.GA14490@ziepe.ca> References: <1514287514-88723-1-git-send-email-oulijun@huawei.com> <1514287514-88723-2-git-send-email-oulijun@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1514287514-88723-2-git-send-email-oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lijun Ou Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxarm-hv44wF8Li93QT0dZR+AlfA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Tue, Dec 26, 2017 at 07:25:09PM +0800, Lijun Ou wrote: > + if (hr_dev->caps.flags & HNS_ROCE_CAP_FLAG_RQ_INLINE) { > + if (hr_qp->rq_inl_buf.wqe_list) { > + kfree(hr_qp->rq_inl_buf.wqe_list[0].sg_list); > + kfree(hr_qp->rq_inl_buf.wqe_list); > + hr_qp->rq_inl_buf.wqe_list[0].sg_list = NULL; You didn't fix this use after free that Leon commented on. nulling something that is contained in something you are about to free is not at all useful. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html