RE: [PATCH for-next] iw_cxgb4: Change error/warn prints to pr_debug

Steve Wise
2017-12-19T21:12:01Z

> On Tue, Dec 19, 2017 at 04:14:16PM +0530, Potnuri Bharat Teja wrote:
> > @@ -64,12 +64,6 @@
> > #define DRV_NAME "iw_cxgb4"
> > #define MOD DRV_NAME ":"
> >
> > -#ifdef pr_fmt
> > -#undef pr_fmt
> > -#endif
> > -
> > -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> > -
>
> Lots of other places in RDMA set a prefix, can we come to some agreement
if
> we
> should drop or keep this unverisally?

Either way we go, pr_fmt being redefined screws up pr_debug() which
optionally prepends the function, line, module names depending on the
dynamic debug settings. You end up with the module name embedded in the
middle of the log statement, and duplicated with +m is used. That is why
Bharat removed it from iw_cxgb4.

In general, I like module names in log statements, but we just need to do it
the right way to avoid the pr_debug issue...

steve

---
This email has been checked for viruses by AVG.