Re: [PATCH for-next] iw_cxgb4: Change error/warn prints to pr_debug

Jason Gunthorpe
2017-12-29T18:09:04Z

On Fri, Dec 29, 2017 at 12:13:38PM +0530, Potnuri Bharat Teja wrote:
> On Friday, December 12/22/17, 2017 at 23:02:07 +0530, Jason Gunthorpe wrote:
> > On Tue, Dec 19, 2017 at 04:32:54PM -0600, Steve Wise wrote:
> >
> > > > > In general, I like module names in log statements, but we just
> > > > > need to do it the right way to avoid the pr_debug issue...
> > > >
> > > > Seems like a bigger problem than for linux-rdma?
> > > >
> > >
> > > If redefining pr_fmt is actually the preferred way to add module names, then
> > > I think pr_debug() might need
> > > to be fixed.
> > >
> > > > Shouldn't many of these prints be using dev_* stuff and be prefixed
> > > > with their device name?
> > >
> > > Yea, that makes sense.
> >
> > Okay, I've dropped this patch.
> >
> > The two changes to pr_debug should probably become dev_dbg, and
> > resend?
> For now I am resending the patch without pr_fmt change.
> dev_dbg change would be an overall change if necessary.

It is not appropriate for a driver to use pr_*, so you should consider
fixing it.

Jason