From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH rdma-next 00/15] Dual Port mlx5 IB Device for RoCE Date: Fri, 29 Dec 2017 14:27:29 -0700 Message-ID: <20171229212729.GH6513@ziepe.ca> References: <20171224125741.25464-1-leon@kernel.org> <382ba516-bf7b-0a0b-7a9f-604cbf805c80@mellanox.com> <20171229180313.GD6513@ziepe.ca> <9d102fb2-122c-d7e9-2521-cf61b708d8c0@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <9d102fb2-122c-d7e9-2521-cf61b708d8c0-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Daniel Jurgens Cc: Or Gerlitz , Doug Ledford , RDMA mailing list , Parav Pandit , Leon Romanovsky , Saeed Mahameed List-Id: linux-rdma@vger.kernel.org On Fri, Dec 29, 2017 at 02:52:18PM -0600, Daniel Jurgens wrote: > On 12/29/2017 12:03 PM, Jason Gunthorpe wrote: > > On Wed, Dec 27, 2017 at 05:20:26PM -0600, Daniel Jurgens wrote: > >> On 12/27/2017 3:22 PM, Or Gerlitz wrote: > >>> On Wed, Dec 27, 2017 at 5:22 PM, Daniel Jurgens wrote: > >>> > >>>> If the PCI device were a slave there would be no IB device for it in the VM. > >>> This creates a regression for users that update their kernel and now > >>> their VMs stop working > >> The feature is not enabled by default. > > You never described how it is enabled in the commit messages either.. > > It's enabled vi FW ini file/PSID or mlxconfig.  Do we ever describe that? If you add a new feature the commit message should briefly discussed how it is used, yes. Just saying 'Dual port mode is enabled by configuring the mlx5 firmware' is probably sufficient in this case. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html