Re: [PATCH rdma-next 1/6] net/mlx5: Add DCT command interface

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1488 bytes --]

On Tue, Jan 02, 2018 at 11:43:27AM +0200, Yuval Shaia wrote:
> On Tue, Dec 26, 2017 at 11:16:29AM +0200, Leon Romanovsky wrote:
> > From: Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> >
> > Add a missing command interface to work with a DCT. It includes: creating,
> > destroying and get events for.
> >
> > Signed-off-by: Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > Reviewed-by: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > ---
> >  drivers/net/ethernet/mellanox/mlx5/core/eq.c |   9 +-
> >  drivers/net/ethernet/mellanox/mlx5/core/qp.c | 128 ++++++++++++++++++++++++---
> >  include/linux/mlx5/device.h                  |   9 ++
> >  include/linux/mlx5/driver.h                  |   8 ++
> >  include/linux/mlx5/qp.h                      |  12 +++
> >  5 files changed, 153 insertions(+), 13 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eq.c b/drivers/net/ethernet/mellanox/mlx5/core/eq.c
> > index 60771865c99c..7d3d503fa675 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/eq.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/eq.c
> >
> > +static u64 dct_allowed_event_types(void)
> > +{
> > +	u64 mask;
> > +
> > +	mask = BIT(MLX5_EVENT_TYPE_DCT_DRAINED);
> > +
> > +	return mask;
>
> We don't really need this "mask" variable, right?

I removed it in v1 and it won't be in v2 too.

Thanks

>
> > +}
> > +

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]