From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH] IB/ipoib: Fix for notify send CQ failure messages Date: Tue, 2 Jan 2018 14:24:07 -0700 Message-ID: <20180102212407.GA19027@ziepe.ca> References: <20180102210419.26104.32513.stgit@phlsvlogin03.ph.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180102210419.26104.32513.stgit-u2TXY/5TJkdZ7WVY1cDZ9q2pdiUAq4bhAL8bYrjMMd8@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alex Estrin , Erez Shitrit Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Tue, Jan 02, 2018 at 04:04:20PM -0500, Alex Estrin wrote: > If IB_CQ_REPORT_MISSED_EVENTS flag is passed in ib_req_notify_cq() > it may return positive value indicating non-empty CQ. > If return code not verified the log might be flooded with false > warning messages "request notify on send CQ failed". > > Fixes: commit 8966e28d2e40 ("IB/ipoib: Use NAPI in UD/TX flows") Hurm... It was right before that commit as well.. Erez, why did you change it? + if (ib_req_notify_cq(priv->send_cq, IB_CQ_NEXT_COMP | + IB_CQ_REPORT_MISSED_EVENTS)) { + ipoib_warn(priv, "IPoIB/CM:request notify on send CQ failed\n"); ... - rc = ib_req_notify_cq(priv->send_cq, - IB_CQ_NEXT_COMP | IB_CQ_REPORT_MISSED_EVENTS); - if (rc < 0) - ipoib_warn(priv, "request notify on send CQ failed\n"); Alex, that is not the right format for the Fixes: line.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html