Re: [PATCH] IB/ipoib: Fix for notify send CQ failure messages

Erez Shitrit
2018-01-03T09:33:05Z

On Tue, Jan 2, 2018 at 11:24 PM, Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> wrote:
> On Tue, Jan 02, 2018 at 04:04:20PM -0500, Alex Estrin wrote:
>> If IB_CQ_REPORT_MISSED_EVENTS flag is passed in ib_req_notify_cq()
>> it may return positive value indicating non-empty CQ.
>> If return code not verified the log might be flooded with false
>> warning messages "request notify on send CQ failed".
>>
>> Fixes: commit 8966e28d2e40 ("IB/ipoib: Use NAPI in UD/TX flows")
>
> Hurm... It was right before that commit as well..
>
> Erez, why did you change it?

I don't think i changed it.

anyway, Alex's patch makes sense, even it is a rare case anyway, and
no flooded will happened.

>
> + if (ib_req_notify_cq(priv->send_cq, IB_CQ_NEXT_COMP |
> + IB_CQ_REPORT_MISSED_EVENTS)) {
> + ipoib_warn(priv, "IPoIB/CM:request notify on send CQ failed\n");
> ...
> - rc = ib_req_notify_cq(priv->send_cq,
> - IB_CQ_NEXT_COMP | IB_CQ_REPORT_MISSED_EVENTS);
> - if (rc < 0)
> - ipoib_warn(priv, "request notify on send CQ failed\n");
>
> Alex, that is not the right format for the Fixes: line..
>
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html