RE: [PATCH] IB/ipoib: Fix for notify send CQ failure messages

Estrin, Alex
2018-01-03T12:03:48Z

> -----Original Message-----
> From: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-rdma-
> owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Jason Gunthorpe
> Sent: Tuesday, January 2, 2018 4:24 PM
> To: Estrin, Alex <alex.estrin-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>; Erez Shitrit <erezsh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Subject: Re: [PATCH] IB/ipoib: Fix for notify send CQ failure messages
>
> On Tue, Jan 02, 2018 at 04:04:20PM -0500, Alex Estrin wrote:
> > If IB_CQ_REPORT_MISSED_EVENTS flag is passed in ib_req_notify_cq()
> > it may return positive value indicating non-empty CQ.
> > If return code not verified the log might be flooded with false
> > warning messages "request notify on send CQ failed".
> >
> > Fixes: commit 8966e28d2e40 ("IB/ipoib: Use NAPI in UD/TX flows")
>
> Hurm... It was right before that commit as well..
>
> Erez, why did you change it?
>
> + if (ib_req_notify_cq(priv->send_cq, IB_CQ_NEXT_COMP |
> + IB_CQ_REPORT_MISSED_EVENTS)) {
> + ipoib_warn(priv, "IPoIB/CM:request notify on send CQ failed\n");
> ...
> - rc = ib_req_notify_cq(priv->send_cq,
> - IB_CQ_NEXT_COMP | IB_CQ_REPORT_MISSED_EVENTS);
> - if (rc < 0)
> - ipoib_warn(priv, "request notify on send CQ failed\n");
>
> Alex, that is not the right format for the Fixes: line..

Jason, thanks for noticing. I'll resend v2
Alex.

> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html