From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH] IB/ipoib: Fix for notify send CQ failure messages Date: Wed, 3 Jan 2018 09:06:48 -0700 Message-ID: <20180103160648.GD11348@ziepe.ca> References: <20180102210419.26104.32513.stgit@phlsvlogin03.ph.intel.com> <20180102212407.GA19027@ziepe.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Erez Shitrit Cc: Alex Estrin , Erez Shitrit , RDMA mailing list List-Id: linux-rdma@vger.kernel.org On Wed, Jan 03, 2018 at 11:33:05AM +0200, Erez Shitrit wrote: > On Tue, Jan 2, 2018 at 11:24 PM, Jason Gunthorpe wrote: > > On Tue, Jan 02, 2018 at 04:04:20PM -0500, Alex Estrin wrote: > >> If IB_CQ_REPORT_MISSED_EVENTS flag is passed in ib_req_notify_cq() > >> it may return positive value indicating non-empty CQ. > >> If return code not verified the log might be flooded with false > >> warning messages "request notify on send CQ failed". > >> > >> Fixes: commit 8966e28d2e40 ("IB/ipoib: Use NAPI in UD/TX flows") > > > > Hurm... It was right before that commit as well.. > > > > Erez, why did you change it? > > I don't think i changed it. Okay, then it is a typo when you reworked things for NAPI that the >0 case started making warnings. I will apply this patch. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html