Re: [PATCH V2 for-next 7/7] RDMA/hns: Set the guid for hip08 RoCE device

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2869 bytes --]

On Wed, Jan 10, 2018 at 05:23:41PM +0800, oulijun wrote:
> 在 2018/1/10 14:49, Leon Romanovsky 写道:
> > On Wed, Jan 10, 2018 at 02:39:53PM +0800, Lijun Ou wrote:
> >> This patch assgin a guid(Global Unique identifer)
> >> value to the hip08 device.
> >>
> >> Signed-off-by: Lijun Ou <oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> >> Signed-off-by: Yixian Liu <liuyixian-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> >> Signed-off-by: Wei Hu (Xavier) <xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> >> ---
> >> V2:
> >> - Use the correct way to update guid from Leon
> >>   Romanovsky's review.
> >>
> >> V1:
> >> - The initial submit
> >> ---
> >>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> >> index a1839a3..2af4948 100644
> >> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> >> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> >> @@ -34,6 +34,7 @@
> >>  #include <linux/etherdevice.h>
> >>  #include <linux/interrupt.h>
> >>  #include <linux/kernel.h>
> >> +#include <net/addrconf.h>
> >>  #include <rdma/ib_umem.h>
> >>
> >>  #include "hnae3.h"
> >> @@ -4679,6 +4680,9 @@ static int hns_roce_hw_v2_get_cfg(struct hns_roce_dev *hr_dev,
> >>  	hr_dev->iboe.netdevs[0] = handle->rinfo.netdev;
> >>  	hr_dev->iboe.phy_port[0] = 0;
> >>
> >> +	addrconf_addr_eui48((u8 *)&hr_dev->ib_dev.node_guid,
> >> +			    hr_dev->iboe.netdevs[0]->dev_addr);
> >> +
> >
> > Are you sure that it is right thing to do?
> >
> > ib_dev.node_guid is __be64 and you cast it for u8.
> >
> > Maybe, it is right, but I don't have ability to test it now.
> >
> > Thanks
> Yes, it can be get rightly. I have test it again
> The test result as follows:
>
> root@(none)# cat /sys/class/infiniband/hns_0/node_guid
> 5816:89ff:fe28:a34b
>
> Besides, I confirm the orign definition for addrconf_addr_eui48, it defined as follows:
> static inline void addrconf_addr_eui48(u8 *eui, const char *const addr)
> {
> 	addrconf_addr_eui48_base(eui, addr);
> 	eui[0] ^= 2;
> }
>
> The first input parameter type is u8 * and the patch [v4] {net,IB}/{rxe,usnic}: Utilize generic mac to eui32 function
> have the same usage.

Indeed the first parameter is u8, but you are converting from __be64 to be u8.

Thanks

>
> Thanks
> Lijun Ou
>
> >
> >>  	for (i = 0; i < HNS_ROCE_V2_MAX_IRQ_NUM; i++)
> >>  		hr_dev->irq[i] = pci_irq_vector(handle->pdev,
> >>  						i + handle->rinfo.base_vector);
> >> --
> >> 1.9.1
> >>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]