Re: [PATCH rdma-next v3 2/7] RDMA/core: Add helper function to create named QPs

Bart Van Assche
2018-01-11T19:50:21Z

On Thu, 2018-01-11 at 17:31 +0200, Leon Romanovsky wrote:
> --- a/include/rdma/ib_verbs.h
> +++ b/include/rdma/ib_verbs.h
> @@ -1141,6 +1141,12 @@ struct ib_qp_init_attr {
> u8 port_num;
> struct ib_rwq_ind_table *rwq_ind_tbl;
> u32 source_qpn;
> +
> + /*
> + * Name of entity which created this QP, empty string means that
> + * it will be taken automatically from task_struct.
> + */
> + char comm[TASK_COMM_LEN];
> };

Why is "comm" a char array instead of a const char pointer or dynamically
allocated memory (kstrdup())? Can we get rid of the strncpy() calls in code
that fills in this data structure?

Thanks,

Bart.