Re: [PATCH rdma-next v3 1/7] RDMA/restrack: Add general infrastructure to track RDMA resources

Bart Van Assche
2018-01-11T19:47:27Z

On Thu, 2018-01-11 at 17:31 +0200, Leon Romanovsky wrote:
> +struct rdma_restrack_entry {
> + struct list_head list;
> +
> + /*
> + * The entries are filled during rdma_restrack_add,
> + * can be attempted to be free during rdma_restrack_del.
> + *
> + * As an example for that, see mlx5 QPs with type MLX5_IB_QPT_HW_GSI
> + */
> + bool valid;
> +
> + /*
> + * Sleepabale RCU to protect object data.
> + */
> + struct srcu_struct srcu;
> +
> + struct task_struct *task;
> + char *task_comm;
> +};

Please use the kernel-doc syntax to document the meaning of the names of the
fields in this structure. It is e.g. nontrivial to guess what "task_comm" stands
for. The presense of a task_struct pointer is also nontrivial.

PS: I think the spelling of "Sleepabale" should be fixed.

Thanks,

Bart.