Building rdma-core from github gave an error "Unknown arguments specified"

Building rdma-core from github gave an error "Unknown arguments specified"

[Kevin Wilson]

Hi,
I had cloned the latest rdma-core:
https://github.com/linux-rdma/rdma-core.git

I am trying to build it on Fedora 27 x86_64 machine.
When I ran:
bash build.sh
I got the following:

CMake Error at buildlib/RDMA_BuildType.cmake:32 (if):
  if given arguments:

    "STREQUAL" "-O2 -g -DNDEBUG"

  Unknown arguments specified
Call Stack (most recent call first):
  CMakeLists.txt:145 (RDMA_BuildType)


-- Configuring incomplete, errors occurred!
See also "/work/down/temp/rdma-core/build/CMakeFiles/CMakeOutput.log".
See also "/work/down/temp/rdma-core/build/CMakeFiles/CMakeError.log".

Any ideas what can it be ?

More details:
As said, I am on the latest git commit, on the master branch:
git log | more
commit c4345781db3d4d24578873b612357124c6b3d1e3
Author: Benjamin Drung <benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
Date:   Thu Jan 4 15:27:51 2018 +0100

    debian: Update changelog to include Debian uploads 16.x

Regards,
KW
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Building rdma-core from github gave an error "Unknown arguments specified"

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]

On Fri, Jan 12, 2018 at 11:35:04AM +0200, Kevin Wilson wrote:
> Hi,
> I had cloned the latest rdma-core:
> https://github.com/linux-rdma/rdma-core.git
>
> I am trying to build it on Fedora 27 x86_64 machine.
> When I ran:
> bash build.sh
> I got the following:
>
> CMake Error at buildlib/RDMA_BuildType.cmake:32 (if):
>   if given arguments:
>
>     "STREQUAL" "-O2 -g -DNDEBUG"
>
>   Unknown arguments specified
> Call Stack (most recent call first):
>   CMakeLists.txt:145 (RDMA_BuildType)
>
>
> -- Configuring incomplete, errors occurred!
> See also "/work/down/temp/rdma-core/build/CMakeFiles/CMakeOutput.log".
> See also "/work/down/temp/rdma-core/build/CMakeFiles/CMakeError.log".
>
> Any ideas what can it be ?

Most probably, there is a missing build dependency.
I tested clean fc27 build in container and it worked flawlessly.
https://patchwork.kernel.org/patch/10160339/

Thanks

>
> More details:
> As said, I am on the latest git commit, on the master branch:
> git log | more
> commit c4345781db3d4d24578873b612357124c6b3d1e3
> Author: Benjamin Drung <benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
> Date:   Thu Jan 4 15:27:51 2018 +0100
>
>     debian: Update changelog to include Debian uploads 16.x
>
> Regards,
> KW
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Building rdma-core from github gave an error "Unknown arguments specified"

[Jason Gunthorpe]

On Fri, Jan 12, 2018 at 11:35:04AM +0200, Kevin Wilson wrote:
> Hi,
> I had cloned the latest rdma-core:
> https://github.com/linux-rdma/rdma-core.git
> 
> I am trying to build it on Fedora 27 x86_64 machine.
> When I ran:
> bash build.sh
> I got the following:
> 
> CMake Error at buildlib/RDMA_BuildType.cmake:32 (if):
>   if given arguments:
> 
>     "STREQUAL" "-O2 -g -DNDEBUG"
> 
>   Unknown arguments specified
> Call Stack (most recent call first):
>   CMakeLists.txt:145 (RDMA_BuildType)

No idea.. Can't reproduce.

I wonder if some quotes are missing:

diff --git a/buildlib/RDMA_BuildType.cmake b/buildlib/RDMA_BuildType.cmake
index 0951edadeebf61..ea2bbf8e639c2f 100644
--- a/buildlib/RDMA_BuildType.cmake
+++ b/buildlib/RDMA_BuildType.cmake
@@ -29,7 +29,7 @@ function(RDMA_BuildType)
   # with the -DNDEBUG removed
   foreach (language CXX C)
     set(VAR_TO_MODIFY "CMAKE_${language}_FLAGS_RELWITHDEBINFO")
-    if (${${VAR_TO_MODIFY}} STREQUAL ${${VAR_TO_MODIFY}_INIT})
+    if ("${${VAR_TO_MODIFY}}" STREQUAL ${${VAR_TO_MODIFY}_INIT})
 	string(REGEX REPLACE "(^| )[/-]D *NDEBUG($| )"
 	  " "
 	  replacement
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html