Re: [PATCH rdma-rc 0/4] RDMA mlx4/mlx5 fixes

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1323 bytes --]

On Fri, Jan 12, 2018 at 10:02:28AM -0700, Jason Gunthorpe wrote:
> On Fri, Jan 12, 2018 at 07:58:38AM +0200, Leon Romanovsky wrote:
>
> So, my take on the for-rc8-ness, based on the commit messages alone:
>
> > Bodong Wang (1):
> >   IB/core: Fix ib_wc structure size to remain in 64 bytes boundary
>
> No, performance optimization only, and not a regression in this cycle
>

Sorry, but it is fix to performance regression, and not optimization.

> > Jack Morgenstein (1):
> >   IB/mlx4: Fix incorrectly releasing steerable UD QPs when have only ETH
> >     ports
>
> No, only supresses an annoying warning
>
> > Leon Romanovsky (1):
> >   RDMA/mlx5: Fix out-of-bound access while querying AH
>
> Yes, fixes a user triggerable out of bounds access

Right

>
> > Parav Pandit (1):
> >   RDMA/core: Fix avoid decoding iWarp port as RoCE
>
> Unknown, commit message is too short. Parav, please explain more why this
> this is worthy of 'CC: stable' ?

Parav has nothing to do with "CC: stable@", I'm the person who added it.

The rationale behind it that it so basic change so it worth to have in
stable. Also, it goes as all our countless fixes to those two series:
Fixes: 44c58487d51a ("IB/core: Define 'ib' and 'roce' rdma_ah_attr types")
Fixes: 7db20ecd1d97 ("IB/core: Change wc.slid from 16 to 32 bits")

Thanks

> Jason

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]