public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Doug Ledford <dledford@redhat.com>,
	Max Gurtovoy <maxg@mellanox.com>,
	Sagi Grimberg <sagi@grimberg.me>,
	"Amrani, Ram" <Ram.Amrani@cavium.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	target-devel <target-devel@vger.kernel.org>
Subject: Re: [PATCH] iser-target: Fix possible use-after-free in connection establishment error
Date: Sat, 13 Jan 2018 11:08:41 -0700	[thread overview]
Message-ID: <20180113180841.GB32353@ziepe.ca> (raw)
In-Reply-To: <1515822365.24576.100.camel@haakon3.daterainc.com>

On Fri, Jan 12, 2018 at 09:46:05PM -0800, Nicholas A. Bellinger wrote:
> On Wed, 2018-01-10 at 16:54 -0500, Doug Ledford wrote:
> > On Tue, 2018-01-09 at 10:17 -0700, Jason Gunthorpe wrote:
> > > On Tue, Jan 09, 2018 at 07:04:16PM +0200, Max Gurtovoy wrote:
> > > > hi Guys,
> > > > did we forget taking this fix to mainline/stable or we found another
> > > > solution ?
> > > 
> > > I thought it was going to NAB's tree.. My mistake, I put it back into
> > > patchworks and it will get into for-next
> > 
> > In fairness, the email thread said exactly that.  But, it never got
> > picked up by NAB.  And being that it's in our tree and calling an rdma-
> > core function, it can easily enough go through our tree, so I applied it
> > to for-rc.
> 
> Thanks Sagi + Ram, and Doug for picking this up.
> 
> Per the earlier discussion, it looks like this needs a stable CC,
> right..?  As Sagi mentioned, it's not clear if this is a regression vs.
> generic RDMA READ/WRITE API logic, or a day one issue.
> 
> So how about adding a 4.7+ stable tag, to match commit a060b5629..?

That can be done:

Fixes: a060b5629ab0 ("IB/core: generic RDMA READ/WRITE API")
Cc: <stable@vger.kernel.org> # 4.7+
Reported-by: Amrani, Ram <Ram.Amrani@cavium.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Doug Ledford <dledford@redhat.com>

Doug: I took your wip/dl-for-rc branch, revised the commit message and
pushed it to for-rc.

Jason

  reply	other threads:[~2018-01-13 18:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-26 13:31 [PATCH] iser-target: Fix possible use-after-free in connection establishment error Sagi Grimberg
     [not found] ` <20171126133104.22710-1-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-11-26 13:59   ` Sagi Grimberg
2017-11-28 11:51     ` Amrani, Ram
     [not found]     ` <3676820c-544e-8ced-859a-ade8e6a0ef53-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-11-29  5:55       ` Amrani, Ram
2017-11-29 22:46         ` Sagi Grimberg
2018-01-09 17:04           ` Max Gurtovoy
2018-01-09 17:17             ` Jason Gunthorpe
     [not found]               ` <20180109171718.GC4518-uk2M96/98Pc@public.gmane.org>
2018-01-10  7:42                 ` Amrani, Ram
2018-01-10 21:54               ` Doug Ledford
2018-01-13  5:46                 ` Nicholas A. Bellinger
2018-01-13 18:08                   ` Jason Gunthorpe [this message]
     [not found]                     ` <20180113180841.GB32353-uk2M96/98Pc@public.gmane.org>
2018-01-14  9:24                       ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180113180841.GB32353@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=Ram.Amrani@cavium.com \
    --cc=dledford@redhat.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=maxg@mellanox.com \
    --cc=nab@linux-iscsi.org \
    --cc=sagi@grimberg.me \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox