Re: [PATCH rdma-rc 0/4] RDMA mlx4/mlx5 fixes

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2084 bytes --]

On Sat, Jan 13, 2018 at 12:18:06PM -0700, Jason Gunthorpe wrote:
> On Fri, Jan 12, 2018 at 08:39:58PM +0200, Leon Romanovsky wrote:
> > On Fri, Jan 12, 2018 at 10:02:28AM -0700, Jason Gunthorpe wrote:
> > > On Fri, Jan 12, 2018 at 07:58:38AM +0200, Leon Romanovsky wrote:
> > >
> > > So, my take on the for-rc8-ness, based on the commit messages alone:
> > >
> > > > Bodong Wang (1):
> > > >   IB/core: Fix ib_wc structure size to remain in 64 bytes boundary
> > >
> > > No, performance optimization only, and not a regression in this cycle
> > >
> >
> > Sorry, but it is fix to performance regression, and not optimization.
>
> regression across multiple kernel cycles and not a regression in this
> cycle. So the performance optimization needs to be justified to raise
> to 'important'. There is no performance data in the commit message, so
> I can't judge it as OK for for-rc
>
> > > > Parav Pandit (1):
> > > >   RDMA/core: Fix avoid decoding iWarp port as RoCE
> > >
> > > Unknown, commit message is too short. Parav, please explain more why this
> > > this is worthy of 'CC: stable' ?
> >
> > Parav has nothing to do with "CC: stable@", I'm the person who added it.
> >
> > The rationale behind it that it so basic change so it worth to have in
> > stable. Also, it goes as all our countless fixes to those two series:
> > Fixes: 44c58487d51a ("IB/core: Define 'ib' and 'roce' rdma_ah_attr types")
> > Fixes: 7db20ecd1d97 ("IB/core: Change wc.slid from 16 to 32 bits")
>
> Nevertheless, the commit message does not explain to me or Linus why
> this is *important* - it does not talk about what user visible
> consequnce there is to this bug.

I'm a little bit confused here, when I submitted Fixes to -next, you
asked from em to send such patches to -rc and now you are asking to send
Fixes to -next.

It will be better if you and Doug have more clear definition for -rc
than LOC count and gut feelings.

For example, Dave took this series for -rc7/8, because it fixes the code
and don't add new features.
https://www.spinics.net/lists/netdev/msg477875.html

Thanks

>
> Jason

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]