From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH v1 01/12] rdma/ib: Add trace point macros to display human-readable values Date: Thu, 18 Jan 2018 15:34:46 -0700 Message-ID: <20180118223446.GB17294@ziepe.ca> References: <20171220210236.29321.59307.stgit@manet.1015granger.net> <20171220213023.29321.97527.stgit@manet.1015granger.net> <1245d090-99ee-c517-5f8f-afdb7ffc0456@Netapp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1245d090-99ee-c517-5f8f-afdb7ffc0456-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Anna Schumaker Cc: Chuck Lever , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Thu, Jan 18, 2018 at 04:49:20PM -0500, Anna Schumaker wrote: > Hi Folks, > > On 12/20/2017 04:30 PM, Chuck Lever wrote: > > These can be shared with all kernel ULPs, and more can easily be > > added as needed. > > > > Note: checkpatch.pl has some heartburn with the TRACE_DEFINE_ENUM > > macros and the LIST macros. These follow the same style as other > > header files under include/tracing/events , thus should be > > considered acceptable exceptions. > > > > Signed-off-by: Chuck Lever > > include/trace/events/rdma.h | 128 +++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 128 insertions(+) > > create mode 100644 include/trace/events/rdma.h > > Just checking that it's okay to send this through the NFS tree, > since it goes along with the rest of Chuck's patches? New file, won't create any conflicts, so should be fine. Is this API or anything that needs a really special look? > > +++ b/include/trace/events/rdma.h > > @@ -0,0 +1,128 @@ > > +/* > > + * Copyright (c) 2017 Oracle. All rights reserved. > > + */ This should have a SPDX header though, from what I understand. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html