[PATCH rdma-next v1] RDMA/mlx5: Remove redundant allocation warning print

[PATCH rdma-next v1] RDMA/mlx5: Remove redundant allocation warning print

[Leon Romanovsky]

From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

The kmalloc() failure to allocate memory generates enough information
and doesn't need to be accompanied by another driver print.

Fixes: d69a24e03659 ("IB/mlx5: Move IB event processing onto a workqueue")
Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
Changelog:
 v0 -> v1:
  * Fixed type in subject
  * Removed "return" from end of void function
---
 drivers/infiniband/hw/mlx5/main.c | 19 ++++++++-----------
 1 file changed, 8 insertions(+), 11 deletions(-)

diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index f282e281eff2..5007280321b6 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -3345,19 +3345,16 @@ static void mlx5_ib_event(struct mlx5_core_dev *dev, void *context,
 	struct mlx5_ib_event_work *work;

 	work = kmalloc(sizeof(*work), GFP_ATOMIC);
-	if (work) {
-		INIT_WORK(&work->work, mlx5_ib_handle_event);
-		work->dev = dev;
-		work->param = param;
-		work->context = context;
-		work->event = event;
-
-		queue_work(mlx5_ib_event_wq, &work->work);
+	if (!work)
 		return;
-	}

-	dev_warn(&dev->pdev->dev, "%s: mlx5_dev_event: %d, with param: %lu dropped, couldn't allocate memory.\n",
-		 __func__, event, param);
+	INIT_WORK(&work->work, mlx5_ib_handle_event);
+	work->dev = dev;
+	work->param = param;
+	work->context = context;
+	work->event = event;
+
+	queue_work(mlx5_ib_event_wq, &work->work);
 }

 static int set_has_smi_cap(struct mlx5_ib_dev *dev)
--
2.15.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-next v1] RDMA/mlx5: Remove redundant allocation warning print

[Yuval Shaia]

On Fri, Jan 19, 2018 at 01:07:11PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> 
> The kmalloc() failure to allocate memory generates enough information
> and doesn't need to be accompanied by another driver print.
> 
> Fixes: d69a24e03659 ("IB/mlx5: Move IB event processing onto a workqueue")
> Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

> ---
> Changelog:
>  v0 -> v1:
>   * Fixed type in subject
>   * Removed "return" from end of void function
> ---
>  drivers/infiniband/hw/mlx5/main.c | 19 ++++++++-----------
>  1 file changed, 8 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
> index f282e281eff2..5007280321b6 100644
> --- a/drivers/infiniband/hw/mlx5/main.c
> +++ b/drivers/infiniband/hw/mlx5/main.c
> @@ -3345,19 +3345,16 @@ static void mlx5_ib_event(struct mlx5_core_dev *dev, void *context,
>  	struct mlx5_ib_event_work *work;
> 
>  	work = kmalloc(sizeof(*work), GFP_ATOMIC);
> -	if (work) {
> -		INIT_WORK(&work->work, mlx5_ib_handle_event);
> -		work->dev = dev;
> -		work->param = param;
> -		work->context = context;
> -		work->event = event;
> -
> -		queue_work(mlx5_ib_event_wq, &work->work);
> +	if (!work)
>  		return;
> -	}
> 
> -	dev_warn(&dev->pdev->dev, "%s: mlx5_dev_event: %d, with param: %lu dropped, couldn't allocate memory.\n",
> -		 __func__, event, param);
> +	INIT_WORK(&work->work, mlx5_ib_handle_event);
> +	work->dev = dev;
> +	work->param = param;
> +	work->context = context;
> +	work->event = event;
> +
> +	queue_work(mlx5_ib_event_wq, &work->work);
>  }
> 
>  static int set_has_smi_cap(struct mlx5_ib_dev *dev)
> --
> 2.15.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-next v1] RDMA/mlx5: Remove redundant allocation warning print

[Jason Gunthorpe]

On Fri, Jan 19, 2018 at 01:07:11PM +0200, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> 
> The kmalloc() failure to allocate memory generates enough information
> and doesn't need to be accompanied by another driver print.
> 
> Fixes: d69a24e03659 ("IB/mlx5: Move IB event processing onto a workqueue")
> Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Changelog:
>  v0 -> v1:
>   * Fixed type in subject
>   * Removed "return" from end of void function
>  drivers/infiniband/hw/mlx5/main.c | 19 ++++++++-----------
>  1 file changed, 8 insertions(+), 11 deletions(-)

Applied to for-next thanks

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html