Re: [PATCH v4 0/5] IB/srp: Add RDMA/CM support

Doug Ledford
2018-01-17T23:11:24Z

[-- Attachment #1: Type: text/plain, Size: 1896 bytes --]

On Tue, 2018-01-16 at 10:39 -0800, Bart Van Assche wrote:
> Hello Jason and Doug,
>
> The five patches in this series add RDMA/CM support to the SRP
> initiator. Please consider these patches for kernel v4.16.
>
> Thanks,
>
> Bart.
>
> Changes compared to v3:
> - Moved a kobj_ns_drop() call inside an if-statement to keep the grab and put
> ns calls balanced.
>
> Changes compared to v2:
> - Added a patch that exports kobj_ns_grab_current() and kobj_ns_drop().
> - Made the rdma_create_id() call also use the namespace of the process that
> triggered SRP login. Added kobj_ns_grab_current() and kobj_ns_drop() calls
> to the SRP initiator to ensure that that network namespace exists at least
> as long as the SRP channel that is using it.
>
> Changes compared to v1:
> - Use the network namespace of the process that writes into the SRP sysfs login
> attribute in rdma_create_id() and inet_pton_with_scope() calls.
> - Removed an irrelevant part from the RDMA/CM patch description.
>
> Bart Van Assche (5):
> kobject: Export kobj_ns_grab_current() and kobj_ns_drop()
> IB/srp: Use kstrtoull() instead of simple_strtoull()
> IB/srp: Make the path record query error message more informative
> IB/srp: Refactor srp_send_req()
> IB/srp: Add RDMA/CM support
>
> drivers/infiniband/ulp/srp/ib_srp.c | 762 ++++++++++++++++++++++++++++--------
> drivers/infiniband/ulp/srp/ib_srp.h | 42 +-
> include/scsi/srp.h | 17 +
> lib/kobject.c | 2 +
> 4 files changed, 654 insertions(+), 169 deletions(-)
>

The patchset looks pretty good now, but obviously we need an ack from
Greg before patch 1 can be applied.

--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]