Re: [PATCH for-next v2 15/16] IB/core: Map iWarp AH type to undefined in rdma_ah_find_type

Dennis Dalessandro
2018-01-29T13:24:52Z

On 1/26/2018 5:32 PM, Jason Gunthorpe wrote:
>> if (rdma_protocol_roce(dev, port_num))
>> return RDMA_AH_ATTR_TYPE_ROCE;
>> + else if (rdma_protocol_iwarp(dev, port_num))
>> + return RDMA_AH_ATTR_TYPE_UNDEFINED;
>> else if ((rdma_protocol_ib(dev, port_num)) &&
>> (rdma_cap_opa_ah(dev, port_num)))
>> return RDMA_AH_ATTR_TYPE_OPA;
>
> Let's not add an UNDEFINED type in the middle of an if casecade with an all
> other cases fall through please:

Sounds reasonable to me, we will fix that up.

> I'm not sure sending all these unrelated patches in one series is such
> a helpful idea. Lot of trouble for everyone just to respond to one
> minor comment.
>
> This series looks like 4-5 topics to me:
> - Optimize HFI
> - 2 patches realted to the interrupt race
> - Random driver fixes
> - IPoIB fix
> - This patch

Totally agree. I have been just batching up all our patches at once and
sending as that is what Doug preferred at one time. Driver is a
different animal though at this point I guess. So I can start breaking
them into logical series again.

How about just drop this series from patchworks and I'll resubmit with
it broken out into multiple patch sets?

-Denny