Re: [PATCH rdma-next 3/5] IB/core: Avoid SGID attributes query while converting GID from OPA to IB

Yuval Shaia
2018-01-28T11:11:03Z

On Sun, Jan 28, 2018 at 11:25:31AM +0200, Leon Romanovsky wrote:
> From: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> SGID attributes are not used during OPA to IB GID conversion.
> Therefore don't query it.
>
> Signed-off-by: Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
> drivers/infiniband/core/cm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
> index b8f8d3128a53..68df93558d80 100644
> --- a/drivers/infiniband/core/cm.c
> +++ b/drivers/infiniband/core/cm.c
> @@ -1577,15 +1577,13 @@ static void cm_opa_to_ib_sgid(struct cm_work *work,
> struct sa_path_rec *path)
> {
> struct ib_device *dev = work->port->cm_dev->ib_device;
> - struct ib_gid_attr gid_attr;
> u8 port_num = work->port->port_num;
>
> if (rdma_cap_opa_ah(dev, port_num) &&
> (ib_is_opa_gid(&path->sgid))) {
> union ib_gid sgid;
>
> - if (ib_get_cached_gid(dev, port_num, 0,
> - &sgid, &gid_attr)) {
> + if (ib_get_cached_gid(dev, port_num, 0, &sgid, NULL)) {
> dev_warn(&dev->dev,
> "Error updating sgid in CM request\n");
> return;

Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

> --
> 2.16.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html