From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuval Shaia Subject: Re: [PATCH rdma-next 4/5] RDMA/cma: Use existing netif_is_bond_master function Date: Sun, 28 Jan 2018 13:22:03 +0200 Message-ID: <20180128112202.GC7001@yuvallap> References: <20180128092533.4156-1-leon@kernel.org> <20180128092533.4156-5-leon@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180128092533.4156-5-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky Cc: Doug Ledford , Jason Gunthorpe , RDMA mailing list , Jack Morgenstein , Mark Bloch , Parav Pandit List-Id: linux-rdma@vger.kernel.org On Sun, Jan 28, 2018 at 11:25:32AM +0200, Leon Romanovsky wrote: > From: Parav Pandit > > When checking whatever the current netdev is the bond master interface, > use kernel API netif_is_bond_master() instead of hardcoding the check. > No functionality is changed. > > Reviewed-by: Mark Bloch > Signed-off-by: Parav Pandit > Signed-off-by: Leon Romanovsky > --- > drivers/infiniband/core/cma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c > index 84812b9dea9b..e66963ca58bd 100644 > --- a/drivers/infiniband/core/cma.c > +++ b/drivers/infiniband/core/cma.c > @@ -4294,7 +4294,7 @@ static int cma_netdev_callback(struct notifier_block *self, unsigned long event, > if (event != NETDEV_BONDING_FAILOVER) > return NOTIFY_DONE; > > - if (!(ndev->flags & IFF_MASTER) || !(ndev->priv_flags & IFF_BONDING)) > + if (!netif_is_bond_master(ndev)) > return NOTIFY_DONE; Reviewed-by: Yuval Shaia > > mutex_lock(&lock); > -- > 2.16.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html