Re: [PATCH rdma-next v7 6/8] RDMA/core: Add resource tracking for create and destroy PDs

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1374 bytes --]

On Sun, Jan 28, 2018 at 01:48:58PM -0700, Jason Gunthorpe wrote:
> On Sun, Jan 28, 2018 at 11:17:23AM +0200, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> >
> > Track create and destroy operations of PD objects.
> >
> > Reviewed-by: Mark Bloch <markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> >  drivers/infiniband/core/uverbs_cmd.c | 2 ++
> >  drivers/infiniband/core/verbs.c      | 5 +++++
> >  2 files changed, 7 insertions(+)
> >
> > diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c
> > index 3e95acd29de7..256934d1f64f 100644
> > +++ b/drivers/infiniband/core/uverbs_cmd.c
> > @@ -340,6 +340,8 @@ ssize_t ib_uverbs_alloc_pd(struct ib_uverbs_file *file,
> >  	uobj->object = pd;
> >  	memset(&resp, 0, sizeof resp);
> >  	resp.pd_handle = uobj->id;
> > +	pd->res.type = RDMA_RESTRACK_PD;
> > +	rdma_restrack_add(&pd->res);
>
> This pattern happens a lot, any reason not to add type to the
> signature of rdma_restrack_add ?

In early versions, I used the suggested signature, but found it clumsy
and liked more this patter, where all restrack functions operates or on
the entry or on the root.

>
> Jason

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]