Re: [PATCH 1/1] IB/rxe: remove redudant parameter in function

Leon Romanovsky
2018-01-30T07:27:22Z

[-- Attachment #1: Type: text/plain, Size: 885 bytes --]

On Tue, Jan 30, 2018 at 02:07:54AM -0500, Zhu Yanjun wrote:
> In the function rxe_av_from_attr, the parameter rxe
> is not used. So it is removed.
>
> CC: Srinivas Eeda <srinivas.eeda-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> CC: Junxiao Bi <junxiao.bi-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Zhu Yanjun <yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
> drivers/infiniband/sw/rxe/rxe_av.c | 4 ++--
> drivers/infiniband/sw/rxe/rxe_loc.h | 4 ++--
> drivers/infiniband/sw/rxe/rxe_qp.c | 5 ++---
> drivers/infiniband/sw/rxe/rxe_verbs.c | 2 +-
> 4 files changed, 7 insertions(+), 8 deletions(-)

Thanks, while you are doing that, can you please change the function
signature to be void? And do the same trick for rxe_av_fill_ip_info(),
it doesn't use rxe too.

Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Thanks

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]