Re: [PATCH 0/6] Trivial patches for SoftRoCE

Yuval Shaia
2018-01-31T12:39:03Z

On Wed, Jan 31, 2018 at 06:06:53AM -0500, Zhu Yanjun wrote:
> Follow advice from Yuval and Leon, to the functions rxe_av_chk_attr,
> rxe_av_to_attr and rxe_av_fill_ip_info, the unnecessary parameter
> are removed and the funtion type are changed to void.
>
> To track the changes to these functions, every change is made
> to a single patch.
>
> Zhu Yanjun (6):
> IB/rxe: remove redudant parameter in function
> IB/rxe: change the function to void from int
> IB/rxe: remove unnecessary parameter in rxe_av_to_attr
> IB/rxe: change the function to void from int
> IB/rxe: change the function rxe_av_fill_ip_info to void
> IB/rxe: remove redudant parameter in rxe_av_fill_ip_info

Since all seems to be related i wonder why not in a single patch.
I assume they will squashed to one before merge, right?

Besides that, for all:

Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

>
> drivers/infiniband/sw/rxe/rxe_av.c | 14 ++++----------
> drivers/infiniband/sw/rxe/rxe_loc.h | 10 ++++------
> drivers/infiniband/sw/rxe/rxe_qp.c | 15 ++++++---------
> drivers/infiniband/sw/rxe/rxe_verbs.c | 10 ++++------
> 4 files changed, 18 insertions(+), 31 deletions(-)
>
> --
> 2.7.4