[PATCH rdma-core] rc_pingpong: Fix getopt processing of -t

[PATCH rdma-core] rc_pingpong: Fix getopt processing of -t

[Jason Gunthorpe]

The -t option never had an argument, a : was erroneously added when
the -c option was added

Fixes: 099c5aa50bc8 ("libibverb/examples: Add command line option to enable buffer validation")
Signed-off-by: Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
 libibverbs/examples/rc_pingpong.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libibverbs/examples/rc_pingpong.c b/libibverbs/examples/rc_pingpong.c
index b5153bceb8254b..cf5c045741b7be 100644
--- a/libibverbs/examples/rc_pingpong.c
+++ b/libibverbs/examples/rc_pingpong.c
@@ -730,7 +730,7 @@ int main(int argc, char *argv[])
 			{}
 		};
 
-		c = getopt_long(argc, argv, "p:d:i:s:m:r:n:l:eg:ot:c",
+		c = getopt_long(argc, argv, "p:d:i:s:m:r:n:l:eg:otc",
 				long_options, NULL);
 
 		if (c == -1)
-- 
2.15.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH rdma-core] rc_pingpong: Fix getopt processing of -t

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

On Tue, Jan 30, 2018 at 05:04:15PM -0700, Jason Gunthorpe wrote:
> The -t option never had an argument, a : was erroneously added when
> the -c option was added
>
> Fixes: 099c5aa50bc8 ("libibverb/examples: Add command line option to enable buffer validation")
> Signed-off-by: Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
>  libibverbs/examples/rc_pingpong.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Thanks, applied.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH rdma-core] rc_pingpong: Fix getopt processing of -t

[Yuval Shaia]

On Tue, Jan 30, 2018 at 05:04:15PM -0700, Jason Gunthorpe wrote:
> The -t option never had an argument, a : was erroneously added when
> the -c option was added

Thanks,
Now i've learned how to add arguments so can implement Ram's idea :)

Sorry for that.

Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

> 
> Fixes: 099c5aa50bc8 ("libibverb/examples: Add command line option to enable buffer validation")
> Signed-off-by: Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
>  libibverbs/examples/rc_pingpong.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libibverbs/examples/rc_pingpong.c b/libibverbs/examples/rc_pingpong.c
> index b5153bceb8254b..cf5c045741b7be 100644
> --- a/libibverbs/examples/rc_pingpong.c
> +++ b/libibverbs/examples/rc_pingpong.c
> @@ -730,7 +730,7 @@ int main(int argc, char *argv[])
>  			{}
>  		};
>  
> -		c = getopt_long(argc, argv, "p:d:i:s:m:r:n:l:eg:ot:c",
> +		c = getopt_long(argc, argv, "p:d:i:s:m:r:n:l:eg:otc",
>  				long_options, NULL);
>  
>  		if (c == -1)
> -- 
> 2.15.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html