From: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH rdma-core] rc_pingpong: Fix getopt processing of -t
Date: Wed, 31 Jan 2018 09:17:02 +0200 [thread overview]
Message-ID: <20180131071700.GA3220@yuvallap> (raw)
In-Reply-To: <20180131000415.GA29879-uk2M96/98Pc@public.gmane.org>
On Tue, Jan 30, 2018 at 05:04:15PM -0700, Jason Gunthorpe wrote:
> The -t option never had an argument, a : was erroneously added when
> the -c option was added
Thanks,
Now i've learned how to add arguments so can implement Ram's idea :)
Sorry for that.
Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> Fixes: 099c5aa50bc8 ("libibverb/examples: Add command line option to enable buffer validation")
> Signed-off-by: Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> libibverbs/examples/rc_pingpong.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libibverbs/examples/rc_pingpong.c b/libibverbs/examples/rc_pingpong.c
> index b5153bceb8254b..cf5c045741b7be 100644
> --- a/libibverbs/examples/rc_pingpong.c
> +++ b/libibverbs/examples/rc_pingpong.c
> @@ -730,7 +730,7 @@ int main(int argc, char *argv[])
> {}
> };
>
> - c = getopt_long(argc, argv, "p:d:i:s:m:r:n:l:eg:ot:c",
> + c = getopt_long(argc, argv, "p:d:i:s:m:r:n:l:eg:otc",
> long_options, NULL);
>
> if (c == -1)
> --
> 2.15.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-01-31 7:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-31 0:04 [PATCH rdma-core] rc_pingpong: Fix getopt processing of -t Jason Gunthorpe
[not found] ` <20180131000415.GA29879-uk2M96/98Pc@public.gmane.org>
2018-01-31 5:58 ` Leon Romanovsky
2018-01-31 7:17 ` Yuval Shaia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180131071700.GA3220@yuvallap \
--to=yuval.shaia-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox