From: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Zhu Yanjun <yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jgg-uk2M96/98Pc@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH 0/6] Trivial patches for SoftRoCE
Date: Wed, 31 Jan 2018 14:39:03 +0200 [thread overview]
Message-ID: <20180131123901.GE10485@yuvallap> (raw)
In-Reply-To: <1517396819-29597-1-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
On Wed, Jan 31, 2018 at 06:06:53AM -0500, Zhu Yanjun wrote:
> Follow advice from Yuval and Leon, to the functions rxe_av_chk_attr,
> rxe_av_to_attr and rxe_av_fill_ip_info, the unnecessary parameter
> are removed and the funtion type are changed to void.
>
> To track the changes to these functions, every change is made
> to a single patch.
>
> Zhu Yanjun (6):
> IB/rxe: remove redudant parameter in function
> IB/rxe: change the function to void from int
> IB/rxe: remove unnecessary parameter in rxe_av_to_attr
> IB/rxe: change the function to void from int
> IB/rxe: change the function rxe_av_fill_ip_info to void
> IB/rxe: remove redudant parameter in rxe_av_fill_ip_info
Since all seems to be related i wonder why not in a single patch.
I assume they will squashed to one before merge, right?
Besides that, for all:
Reviewed-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>
> drivers/infiniband/sw/rxe/rxe_av.c | 14 ++++----------
> drivers/infiniband/sw/rxe/rxe_loc.h | 10 ++++------
> drivers/infiniband/sw/rxe/rxe_qp.c | 15 ++++++---------
> drivers/infiniband/sw/rxe/rxe_verbs.c | 10 ++++------
> 4 files changed, 18 insertions(+), 31 deletions(-)
>
> --
> 2.7.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-31 12:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 7:07 [PATCH 1/1] IB/rxe: remove redudant parameter in function Zhu Yanjun
[not found] ` <1517296074-14459-1-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-01-30 7:27 ` Leon Romanovsky
2018-01-30 7:30 ` Yuval Shaia
2018-01-31 11:06 ` [PATCH 0/6] Trivial patches for SoftRoCE Zhu Yanjun
[not found] ` <1517396819-29597-1-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-01-31 11:06 ` [PATCH 1/6] IB/rxe: remove redudant parameter in function Zhu Yanjun
[not found] ` <1517396819-29597-2-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-01-31 12:36 ` Leon Romanovsky
2018-01-31 11:06 ` [PATCH 2/6] IB/rxe: change the function to void from int Zhu Yanjun
[not found] ` <1517396819-29597-3-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-01-31 12:35 ` Leon Romanovsky
2018-01-31 11:06 ` [PATCH 3/6] IB/rxe: remove unnecessary parameter in rxe_av_to_attr Zhu Yanjun
[not found] ` <1517396819-29597-4-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-01-31 12:35 ` Leon Romanovsky
2018-01-31 11:06 ` [PATCH 4/6] IB/rxe: change the function to void from int Zhu Yanjun
2018-01-31 11:06 ` [PATCH 5/6] IB/rxe: change the function rxe_av_fill_ip_info to void Zhu Yanjun
2018-01-31 11:06 ` [PATCH 6/6] IB/rxe: remove redudant parameter in rxe_av_fill_ip_info Zhu Yanjun
[not found] ` <1517396819-29597-7-git-send-email-yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-01-31 12:35 ` Leon Romanovsky
2018-01-31 12:39 ` Yuval Shaia [this message]
2018-01-31 21:34 ` [PATCH 0/6] Trivial patches for SoftRoCE Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180131123901.GE10485@yuvallap \
--to=yuval.shaia-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jgg-uk2M96/98Pc@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox