Re: [PATCH RFC 2/2] RDMA/nldev: provide detailed CM_ID information

[Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>]

On Thu, Feb 01, 2018 at 12:18:05PM -0600, Steve Wise wrote:
> 
> 
> > From: Jason Gunthorpe [mailto:jgg-uk2M96/98Pc@public.gmane.org]
> > Sent: Thursday, February 01, 2018 11:54 AM
> > To: Leon Romanovsky
> > Cc: Steve Wise; dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > Subject: Re: [PATCH RFC 2/2] RDMA/nldev: provide detailed CM_ID
> information
> > 
> > On Thu, Feb 01, 2018 at 10:49:44AM +0200, Leon Romanovsky wrote:
> > 
> > > > +	RDMA_NLDEV_ATTR_RES_IPV4_SADDR,		/* u8[4] */
> > > > +	RDMA_NLDEV_ATTR_RES_IPV4_DADDR,		/* u8[4] */
> > > > +	RDMA_NLDEV_ATTR_RES_IPV6_SADDR,		/* u8[16] */
> > > > +	RDMA_NLDEV_ATTR_RES_IPV6_DADDR,		/* u8[16] */
> > > > +	RDMA_NLDEV_ATTR_RES_IP_SPORT,		/* BE u16 */
> > > > +	RDMA_NLDEV_ATTR_RES_IP_DPORT,		/* BE u16 */
> > >
> > > Can you please document the meaning of S (source) and D (destination)
> > > in regards of this netlink output? It is needed to remove ambiguity.
> > 
> > And no on BE's in netlink, I think.
> 
> 
> Sure there are, see nla_put_be32() for example. I'm using nla_put_net16() to
> store the ports.  Perhaps I need to change the above comment to ne16 instead
> of BE u16?

There is no reason thes ports should be be, so don't make it be.

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html