From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH for-next] IB/ipoib: Fix for potential no-carrier state Date: Thu, 1 Feb 2018 15:51:45 -0700 Message-ID: <20180201225145.GG8590@ziepe.ca> References: <20180201185533.9091.17941.stgit@scvm10.sc.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180201185533.9091.17941.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dennis Dalessandro Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mike Marciniszyn , Ira Weiny , Alex Estrin List-Id: linux-rdma@vger.kernel.org On Thu, Feb 01, 2018 at 10:55:41AM -0800, Dennis Dalessandro wrote: > From: Alex Estrin > > On reboot SM can program port pkey table before ipoib registered its > event handler, which could result in missing pkey event and leave root > interface with initial pkey value from index 0. > > Since OPA port starts with invalid pkey in index 0, root interface will > fail to initialize and stay down with no-carrier flag. > > For IB ipoib interface may end up with pkey different from value > opensm put in pkey table idx 0, resulting in connectivity issues > (different mcast groups, for example). > > Close the window by calling event handler after registration > to make sure ipoib pkey is in sync with port pkey table. > > Reviewed-by: Mike Marciniszyn > Reviewed-by: Ira Weiny > Signed-off-by: Alex Estrin > Signed-off-by: Dennis Dalessandro > drivers/infiniband/ulp/ipoib/ipoib_main.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) Seemed liked Doug was Ok with the explanation, so applied to for-next Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html