From: Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: yanjzhu <yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: Guanglei Li <guanglei.li-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
junxiao.bi-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
honglei.wang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v2] RDMA/cma: Fix null pointer issue
Date: Fri, 2 Feb 2018 11:38:56 -0700 [thread overview]
Message-ID: <20180202183856.GZ23352@mellanox.com> (raw)
In-Reply-To: <c7f0ebf5-6e67-18d4-c04f-088bb558621d-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
On Fri, Feb 02, 2018 at 03:22:18PM +0800, yanjzhu wrote:
> Hi, Guanglei
>
> The checkpatch checks your patch. The followings are the result.
>
> CHECK: Alignment should match open parenthesis
> #148: FILE: net/rds/ib.c:349:
> + cm_id = rdma_create_id(&init_net, rds_rdma_cm_event_handler,
> + NULL, RDMA_PS_TCP, IB_QPT_RC);
>
> total: 2 errors, 0 warnings, 1 checks, 9 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
> mechanically convert to the typical style using --fix or
>
> 1.patch has style problems, please review.
Also please try to write a more detailed commit message about what can
trigger this.. Is it userspace or remote network?
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-02-02 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-02 6:42 [PATCH v2] RDMA/cma: Fix null pointer issue Guanglei Li
[not found] ` <1517553759-12272-1-git-send-email-guanglei.li-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-02-02 7:22 ` yanjzhu
[not found] ` <c7f0ebf5-6e67-18d4-c04f-088bb558621d-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2018-02-02 18:38 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202183856.GZ23352@mellanox.com \
--to=jgg-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=guanglei.li-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=honglei.wang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=junxiao.bi-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=yanjun.zhu-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox