From: Jason Gunthorpe <jgg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Lijun Ou <oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH for-next 1/3] RDMA/hns: Fix a bug with modifying mac address
Date: Tue, 6 Feb 2018 08:53:38 -0700 [thread overview]
Message-ID: <20180206155338.GG1288@mellanox.com> (raw)
In-Reply-To: <1517920459-93900-2-git-send-email-oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On Tue, Feb 06, 2018 at 08:34:17PM +0800, Lijun Ou wrote:
> When modifying mac address, it will trigger hns_roce_del_gid
> function and can't delete the default gid matched the index
> because the attribute of gid is null.
>
> Signed-off-by: Lijun Ou <oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> drivers/infiniband/hw/hns/hns_roce_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_main.c b/drivers/infiniband/hw/hns/hns_roce_main.c
> index eb9a69f..6f39afb 100644
> +++ b/drivers/infiniband/hw/hns/hns_roce_main.c
> @@ -100,6 +100,7 @@ static int hns_roce_del_gid(struct ib_device *device, u8 port_num,
> unsigned int index, void **context)
> {
> struct hns_roce_dev *hr_dev = to_hr_dev(device);
> + const struct ib_gid_attr zattr;
That is uninited stack memory, need a = {}
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-02-06 15:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 12:34 [PATCH for-next 0/3] Several fixes for hns Lijun Ou
[not found] ` <1517920459-93900-1-git-send-email-oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2018-02-06 12:34 ` [PATCH for-next 1/3] RDMA/hns: Fix a bug with modifying mac address Lijun Ou
[not found] ` <1517920459-93900-2-git-send-email-oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2018-02-06 15:53 ` Jason Gunthorpe [this message]
[not found] ` <20180206155338.GG1288-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2018-02-08 0:58 ` oulijun
2018-02-06 12:34 ` [PATCH for-next 2/3] RDMA/hns: Fix QP state judgement before receiving work requests Lijun Ou
2018-02-06 12:34 ` [PATCH for-next 3/3] RDMA/hns: Use free_pages function instead of free_page Lijun Ou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180206155338.GG1288@mellanox.com \
--to=jgg-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox