From: "ira.weiny" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH infiniband-diags 1/2] smpdump.c: Minor fix for when umad_recv fails
Date: Wed, 7 Feb 2018 00:29:39 -0500 [thread overview]
Message-ID: <20180207052937.GA25132@phlsvsds.ph.intel.com> (raw)
In-Reply-To: <bf63fe27-d04e-140c-6ed2-61a7c719d2ee-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
On Mon, Dec 11, 2017 at 09:57:03AM -0500, Hal Rosenstock wrote:
>
> There is no SMP and hence no SMP in this case.
> Error displayed should be based on errno.
>
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Thanks applied,
Ira
> ---
> src/smpdump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/smpdump.c b/src/smpdump.c
> index 6105ec8..bc8559a 100644
> --- a/src/smpdump.c
> +++ b/src/smpdump.c
> @@ -279,7 +279,7 @@ int main(int argc, char *argv[])
> IBPANIC("send failed");
>
> if (umad_recv(portid, umad, &length, -1) != mad_agent)
> - IBPANIC("recv error: %s", drmad_status_str(smp));
> + IBPANIC("recv error: %s", strerror(errno));
>
> if (!dump_char) {
> xdump(stdout, 0, smp->data, 64);
> --
> 2.8.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-02-07 5:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 14:57 [PATCH infiniband-diags 1/2] smpdump.c: Minor fix for when umad_recv fails Hal Rosenstock
[not found] ` <bf63fe27-d04e-140c-6ed2-61a7c719d2ee-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2018-02-07 5:29 ` ira.weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207052937.GA25132@phlsvsds.ph.intel.com \
--to=ira.weiny-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).