linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH infiniband-diags 1/2] smpdump.c: Minor fix for when umad_recv fails
@ 2017-12-11 14:57 Hal Rosenstock
       [not found] ` <bf63fe27-d04e-140c-6ed2-61a7c719d2ee-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Hal Rosenstock @ 2017-12-11 14:57 UTC (permalink / raw)
  To: Weiny, Ira; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org


There is no SMP and hence no SMP in this case.
Error displayed should be based on errno.

Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
 src/smpdump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/smpdump.c b/src/smpdump.c
index 6105ec8..bc8559a 100644
--- a/src/smpdump.c
+++ b/src/smpdump.c
@@ -279,7 +279,7 @@ int main(int argc, char *argv[])
 		IBPANIC("send failed");
 
 	if (umad_recv(portid, umad, &length, -1) != mad_agent)
-		IBPANIC("recv error: %s", drmad_status_str(smp));
+		IBPANIC("recv error: %s", strerror(errno));
 
 	if (!dump_char) {
 		xdump(stdout, 0, smp->data, 64);
-- 
2.8.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH infiniband-diags 1/2] smpdump.c: Minor fix for when umad_recv fails
       [not found] ` <bf63fe27-d04e-140c-6ed2-61a7c719d2ee-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
@ 2018-02-07  5:29   ` ira.weiny
  0 siblings, 0 replies; 2+ messages in thread
From: ira.weiny @ 2018-02-07  5:29 UTC (permalink / raw)
  To: Hal Rosenstock; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

On Mon, Dec 11, 2017 at 09:57:03AM -0500, Hal Rosenstock wrote:
> 
> There is no SMP and hence no SMP in this case.
> Error displayed should be based on errno.
> 
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>


Thanks applied,
Ira

> ---
>  src/smpdump.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/smpdump.c b/src/smpdump.c
> index 6105ec8..bc8559a 100644
> --- a/src/smpdump.c
> +++ b/src/smpdump.c
> @@ -279,7 +279,7 @@ int main(int argc, char *argv[])
>  		IBPANIC("send failed");
>  
>  	if (umad_recv(portid, umad, &length, -1) != mad_agent)
> -		IBPANIC("recv error: %s", drmad_status_str(smp));
> +		IBPANIC("recv error: %s", strerror(errno));
>  
>  	if (!dump_char) {
>  		xdump(stdout, 0, smp->data, 64);
> -- 
> 2.8.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-02-07  5:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-11 14:57 [PATCH infiniband-diags 1/2] smpdump.c: Minor fix for when umad_recv fails Hal Rosenstock
     [not found] ` <bf63fe27-d04e-140c-6ed2-61a7c719d2ee-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2018-02-07  5:29   ` ira.weiny

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).